Fix bugs found from testing

- Improper buffer used for Utf8SourceInfo
- Unnecessary assert in RunBgParseSync
- Fix additional memory leak before shutdown

Author: Thomas Moore (CHAKRA)

bin/ChakraCore/ChakraCoreDllFunc.cpp

@@ -154,6 +154,7 @@ EXTERN_C BOOL WINAPI DllMain(HINSTANCE hmod, DWORD dwReason, PVOID pvReserved)
         else
         {
             ThreadBoundThreadContextManager::DestroyAllContexts();
+            DetachProcess();
             ThreadContext::ReportAndCheckLeaksOnProcessDetach();
         }
 #endif

bin/ch/HostConfigFlagsList.h

@@ -20,6 +20,6 @@ FLAG(bool, Test262,                         "load Test262 harness", false)
 FLAG(bool, Module,                          "load the script as a module", false)
 FLAG(bool, TrackRejectedPromises,           "Enable tracking of unhandled promise rejections", false)
 FLAG(BSTR, CustomConfigFile,                "Custom config file to be used to pass in additional flags to Chakra", NULL)
-FLAG(bool, ExecuteWithBgParse,              "[No-op] Load script with bgparse (note: requires bgparse to be on as well)", false)
+FLAG(bool, ExecuteWithBgParse,              "Load script with bgparse (note: requires bgparse and parserstatecache be on as well)", false)
 #undef FLAG
 #endif

bin/ch/ch.cpp

@@ -39,6 +39,8 @@ UINT32 snapHistoryLength = MAXUINT32;
 LPCWSTR connectionUuidString = NULL;
 UINT32 startEventCount = 1;
 
+HRESULT RunBgParseSync(LPCSTR fileContents, UINT lengthBytes, const char* fileName);
+
 extern "C"
 HRESULT __stdcall OnChakraCoreLoadedEntry(TestHooks& testHooks)
 {
@@ -462,8 +464,9 @@ HRESULT RunScript(const char* fileName, LPCSTR fileContents, size_t fileLength,
             IfJsErrorFailLog(ChakraRTInterface::JsCreateExternalArrayBuffer((void*)fileContents,
                 (unsigned int)fileLength,
                 fileContentsFinalizeCallback, (void*)fileContents, &scriptSource));
+
 #if ENABLE_TTD
-            if(doTTRecord)
+            if (doTTRecord)
             {
                 JsPropertyIdRef ttProperty = nullptr;
                 JsValueRef ttString = nullptr;
@@ -769,8 +772,7 @@ HRESULT RunBgParseSync(LPCSTR fileContents, UINT lengthBytes, const char* fileNa
     for (int i = 0; i < fileNameLength; i++)
     {
         fileNameWide[i] = fileName[i];
-    }   
-
+    }
 
     JsScriptContents scriptContents = { 0 };
     scriptContents.container = (LPVOID)fileContents;
@@ -793,9 +795,8 @@ HRESULT RunBgParseSync(LPCSTR fileContents, UINT lengthBytes, const char* fileNa
         nullptr,//_In_ JsValueRef parserState,
         &bgResult
     );
-    Assert(e == JsErrorCode::JsNoError);
 
-    return S_OK;
+    return e;
 }
 
 HRESULT ExecuteTest(const char* fileName)

lib/Parser/BGParseManager.cpp

@@ -590,7 +590,7 @@ HRESULT BGParseWorkItem::DeserializeParseResults(
         {
             scriptContextUI->MakeUtf8SourceInfo(
                 this->script,
-                this->parseSourceLength,
+                this->cb,
                 pSrcInfo,
                 &utf8SourceInfo,
                 LoadScriptFlag_Utf8Source,