Skip to content

Commit c322694

Browse files
MSLaguanaAtul Katti
authored andcommitted
[CVE-2018-8291] DictionaryPropertyDescriptor::CopyFrom missed copying some properties
1 parent 0cbed34 commit c322694

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lib/Runtime/Types/DictionaryPropertyDescriptor.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,13 @@ namespace Js
274274
this->Setter = (descriptor.Setter == DictionaryPropertyDescriptor<TPropertyIndexFrom>::NoSlots) ? NoSlots : descriptor.Setter;
275275
this->IsAccessor = descriptor.IsAccessor;
276276

277+
// Not strictly required, PreventFalseReference must always be 1
278+
this->PreventFalseReference = descriptor.PreventFalseReference;
279+
this->IsShadowed = descriptor.IsShadowed;
280+
277281
#if ENABLE_FIXED_FIELDS
278282
this->IsInitialized = descriptor.IsInitialized;
283+
this->IsOnlyOneAccessorInitialized = descriptor.IsOnlyOneAccessorInitialized;
279284
this->IsFixed = descriptor.IsFixed;
280285
this->UsedAsFixed = descriptor.UsedAsFixed;
281286
#endif

0 commit comments

Comments
 (0)