Skip to content

Commit c5a737f

Browse files
BillyONealppenzin
authored andcommitted
Fix build race detected by vcpkg.
In https://dev.azure.com/vcpkg/public/_build/results?buildId=80997 , we observe this error: ``` "D:\buildtrees\chakracore\x86-windows\Build\Chakra.Core.sln" (Rebuild target) (1) -> "D:\buildtrees\chakracore\x86-windows\lib\SCACore\Chakra.SCACore.vcxproj" (Rebuild target) (35) -> (ClCompile target) -> D:\buildtrees\chakracore\x86-windows\lib\Common\Core\EtwTraceCore.h(81,10): fatal error C1083: Cannot open include file: 'Microsoft-Scripting-Chakra-InstrumentationEvents.h': No such file or directory [D:\buildtrees\chakracore\x86-windows\lib\SCACore\Chakra.SCACore.vcxproj] ``` It appears that this is supposed to be a generated header file, but there's no obvious dependency from Chakra.SCACore.vcxproj on CoreManifests.vcxproj which seems to produce that file.
1 parent 20fffa8 commit c5a737f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/SCACore/Chakra.SCACore.vcxproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@
6060
<ClInclude Include="StreamReader.h" />
6161
<ClInclude Include="StreamWriter.h" />
6262
</ItemGroup>
63+
<ItemGroup>
64+
<ProjectReference Include="$(MSBuildThisFileDirectory)../../manifests/CoreManifests.vcxproj" />
65+
</ItemGroup>
6366
<Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
6467
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
6568
</Project>

0 commit comments

Comments
 (0)