Skip to content

Commit cb90e11

Browse files
committed
actually enable caching for CreateKeys enumerator
1 parent ea430d9 commit cb90e11

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/Runtime/Library/JavascriptObject.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1209,7 +1209,7 @@ JavascriptArray* JavascriptObject::CreateKeysHelper(RecyclableObject* object, Sc
12091209
AssertMsg(includeStringProperties || includeSymbolProperties, "Should either get string or symbol properties.");
12101210

12111211
JavascriptStaticEnumerator enumerator;
1212-
EnumeratorFlags flags = EnumeratorFlags::UseCache;
1212+
EnumeratorFlags flags = EnumeratorFlags::SnapShotSemantics | EnumeratorFlags::UseCache;
12131213
JavascriptArray* newArr = scriptContext->GetLibrary()->CreateArray(0);
12141214
if (includeNonEnumerable)
12151215
{

lib/Runtime/Types/DynamicObjectPropertyEnumerator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ namespace Js
7373
Assert(data != nullptr);
7474
Assert(data->scriptContext == this->scriptContext); // The cache data script context should be the same as request context
7575

76-
if (data->enumNonEnumerable == GetEnumNonEnumerable())
76+
if (data->enumNonEnumerable == GetEnumNonEnumerable() && data->enumSymbols == GetEnumSymbols())
7777
{
7878
Initialize(type, data, data->propertyCount);
7979
return true;

0 commit comments

Comments
 (0)