While inlining don't add bytecodeuses of args if it has same bytecodeReg as dst

Meghana Gupta · Meghana Gupta · commit cfd312a1dac3 · 2019-04-05T15:01:56.000-07:00
Fixes #5971
diff --git a/lib/Backend/Inline.cpp b/lib/Backend/Inline.cpp
@@ -2215,7 +2215,7 @@ Inline::InlineBuiltInFunction(
                 StackSym * sym = argInstr->GetSrc1()->GetStackSym();
                 if (!sym->m_isSingleDef || !sym->m_instrDef->GetSrc1() || !sym->m_instrDef->GetSrc1()->IsConstOpnd())
                 {
-                    if (!sym->IsFromByteCodeConstantTable())
+                    if (!sym->IsFromByteCodeConstantTable() && sym->GetByteCodeRegSlot() != callInstrDst->GetStackSym()->GetByteCodeRegSlot())
                     {
                         byteCodeUsesInstr->Set(argInstr->GetSrc1());
                     }

Original file line number	Diff line number	Diff line change
`@@ -2215,7 +2215,7 @@ Inline::InlineBuiltInFunction(`
`2215`	`2215`	`StackSym * sym = argInstr->GetSrc1()->GetStackSym();`
`2216`	`2216`	`if (!sym->m_isSingleDef \|\| !sym->m_instrDef->GetSrc1() \|\| !sym->m_instrDef->GetSrc1()->IsConstOpnd())`
`2217`	`2217`	`{`
`2218`		`- if (!sym->IsFromByteCodeConstantTable())`
	`2218`	`+ if (!sym->IsFromByteCodeConstantTable() && sym->GetByteCodeRegSlot() != callInstrDst->GetStackSym()->GetByteCodeRegSlot())`
`2219`	`2219`	`{`
`2220`	`2220`	`byteCodeUsesInstr->Set(argInstr->GetSrc1());`
`2221`	`2221`	`}`