[MERGE #5929 @meg-gupta] Add boolean fast path in ToBoolean

Meghana Gupta · Meghana Gupta · commit d455ac43cc61 · 2019-02-06T12:05:07.000-08:00
Merge pull request #5929 from pr/meg-gupta/boolfastpath
diff --git a/lib/Runtime/Language/JavascriptConversion.cpp b/lib/Runtime/Language/JavascriptConversion.cpp
@@ -769,9 +769,6 @@ using namespace Js;
         case TypeIds_Symbol:
             return true;
 
-        case TypeIds_Boolean:
-            return UnsafeVarTo<JavascriptBoolean>(aValue)->GetValue();
-
 #if !FLOATVAR
         case TypeIds_Number:
             {
diff --git a/lib/Runtime/Language/JavascriptConversion.inl b/lib/Runtime/Language/JavascriptConversion.inl
@@ -15,7 +15,12 @@ namespace Js {
     inline BOOL JavascriptConversion::ToBoolean(Var aValue,ScriptContext* scriptContext)
     {
         JIT_HELPER_NOT_REENTRANT_HEADER(Conv_ToBoolean, reentrancylock, scriptContext->GetThreadContext());
-        if (TaggedInt::Is(aValue))
+
+        if (VarIs<JavascriptBoolean>(aValue))
+        {
+            return UnsafeVarTo<JavascriptBoolean>(aValue)->GetValue();
+        }
+        else if (TaggedInt::Is(aValue))
         {
             return aValue != reinterpret_cast<Var>(AtomTag_IntPtr);
         }

Original file line number	Diff line number	Diff line change
`@@ -769,9 +769,6 @@ using namespace Js;`
`769`	`769`	`case TypeIds_Symbol:`
`770`	`770`	`return true;`
`771`	`771`
`772`		`- case TypeIds_Boolean:`
`773`		`- return UnsafeVarTo<JavascriptBoolean>(aValue)->GetValue();`
`774`		`-`
`775`	`772`	`#if !FLOATVAR`
`776`	`773`	`case TypeIds_Number:`
`777`	`774`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,12 @@ namespace Js {`
`15`	`15`	`inline BOOL JavascriptConversion::ToBoolean(Var aValue,ScriptContext* scriptContext)`
`16`	`16`	`{`
`17`	`17`	`JIT_HELPER_NOT_REENTRANT_HEADER(Conv_ToBoolean, reentrancylock, scriptContext->GetThreadContext());`
`18`		`- if (TaggedInt::Is(aValue))`
	`18`	`+`
	`19`	`+ if (VarIs<JavascriptBoolean>(aValue))`
	`20`	`+ {`
	`21`	`+ return UnsafeVarTo<JavascriptBoolean>(aValue)->GetValue();`
	`22`	`+ }`
	`23`	`+ else if (TaggedInt::Is(aValue))`
`19`	`24`	`{`
`20`	`25`	`return aValue != reinterpret_cast<Var>(AtomTag_IntPtr);`
`21`	`26`	`}`