[MERGE #5468 @sethbrenith] Fix a few static analysis warnings

Merge pull request #5468 from sethbrenith:user/sethb/prefast-2

Fixes OS:18281928
Fixes OS:18281785
Fixes OS:18273031

Author: sethbrenith

lib/Common/Core/ConfigParser.cpp

@@ -358,7 +358,7 @@ void ConfigParser::ParseRegistryKey(HKEY hk, CmdLineArgsParser &parser)
 
 #ifdef _WIN32
 
-void ConfigParser::SetConfigStringFromRegistry(_In_ HKEY hk, _In_ const char16* subKeyName, _In_ const char16* valName, _Inout_ Js::String& str)
+void ConfigParser::SetConfigStringFromRegistry(_In_ HKEY hk, _In_z_ const char16* subKeyName, _In_z_ const char16* valName, _Inout_ Js::String& str)
 {
     const char16* regValue = nullptr;
     DWORD len = 0;
@@ -376,7 +376,7 @@ void ConfigParser::SetConfigStringFromRegistry(_In_ HKEY hk, _In_ const char16*
  * doesn't exist, or if we can't allocate memory.  
  * Will allocate a char16* buffer on the heap. Caller is responsible for freeing.
  */
-void ConfigParser::ReadRegistryString(_In_ HKEY hk, _In_ const char16* subKeyName, _In_ const char16* valName, _Out_ const char16** sz, _Out_ DWORD* length)
+void ConfigParser::ReadRegistryString(_In_ HKEY hk, _In_z_ const char16* subKeyName, _In_z_ const char16* valName, _Outptr_result_maybenull_z_ const char16** sz, _Out_ DWORD* length)
 {
     DWORD bufLength = 0;
     *length = 0;

lib/Common/Core/ConfigParser.h

@@ -40,8 +40,8 @@ class ConfigParser
     void ParseRegistryKey(HKEY hk, CmdLineArgsParser &parser);
 
 #ifdef _WIN32
-    static void ConfigParser::SetConfigStringFromRegistry(_In_ HKEY hk, _In_ const char16* subKeyName, _In_ const char16* valName, _Inout_ Js::String& str);
-    static void ConfigParser::ReadRegistryString(_In_ HKEY hk, _In_ const char16* subKeyName, _In_ const char16* valName, _Out_ const char16** sz, _Out_ DWORD* length);
+    static void ConfigParser::SetConfigStringFromRegistry(_In_ HKEY hk, _In_z_ const char16* subKeyName, _In_z_ const char16* valName, _Inout_ Js::String& str);
+    static void ConfigParser::ReadRegistryString(_In_ HKEY hk, _In_z_ const char16* subKeyName, _In_z_ const char16* valName, _Outptr_result_maybenull_z_ const char16** sz, _Out_ DWORD* length);
 #endif
 
 public:

lib/Runtime/Library/JavascriptLibrary.cpp

@@ -403,18 +403,20 @@ namespace Js
         strictHeapArgumentsTypePath->Add<true /*isSetter*/>(BuiltInPropertyRecords::callee);
         strictHeapArgumentsTypePath->Add(BuiltInPropertyRecords::length);
         strictHeapArgumentsTypePath->Add(BuiltInPropertyRecords::_symbolIterator);
-        ObjectSlotAttributes *strictHeapArgumentsAttributes = RecyclerNewArrayLeaf(recycler, ObjectSlotAttributes, strictHeapArgumentsTypePath->GetPathSize());
+        uint8 strictHeapArgumentsTypePathSize = strictHeapArgumentsTypePath->GetPathSize();
+        AnalysisAssert(strictHeapArgumentsTypePathSize >= 4);
+        ObjectSlotAttributes *strictHeapArgumentsAttributes = RecyclerNewArrayLeaf(recycler, ObjectSlotAttributes, strictHeapArgumentsTypePathSize);
         strictHeapArgumentsAttributes[0] = (ObjectSlotAttributes)(ObjectSlotAttr_Writable | ObjectSlotAttr_Accessor);
         strictHeapArgumentsAttributes[1] = ObjectSlotAttr_Setter;
         strictHeapArgumentsAttributes[2] = (ObjectSlotAttributes)PropertyBuiltInMethodDefaults;
         strictHeapArgumentsAttributes[3] = (ObjectSlotAttributes)PropertyBuiltInMethodDefaults;
-        for (int i = 4; i < strictHeapArgumentsTypePath->GetPathSize(); ++i)
+        for (int i = 4; i < strictHeapArgumentsTypePathSize; ++i)
         {
             strictHeapArgumentsAttributes[i] = ObjectSlotAttr_Default;
         }
-        PathTypeSetterSlotIndex * strictHeapArgumentsSetters = RecyclerNewArrayLeaf(recycler, PathTypeSetterSlotIndex, strictHeapArgumentsTypePath->GetPathSize());
+        PathTypeSetterSlotIndex * strictHeapArgumentsSetters = RecyclerNewArrayLeaf(recycler, PathTypeSetterSlotIndex, strictHeapArgumentsTypePathSize);
         strictHeapArgumentsSetters[0] = 1;
-        for (int i = 1; i < strictHeapArgumentsTypePath->GetPathSize(); ++i)
+        for (int i = 1; i < strictHeapArgumentsTypePathSize; ++i)
         {
             strictHeapArgumentsSetters[i] = NoSetterSlot;
         }