Skip to content

Commit de2d7f8

Browse files
committed
[MERGE #6141 @MikeHolman] workaround MSVC codegen bug
Merge pull request #6141 from MikeHolman:workaroundcompiler In some cases MSVC generates bad code here. This change seems to fix the issue
2 parents ec1e3dd + 7cce632 commit de2d7f8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/Runtime/Library/EngineInterfaceObject.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,8 @@ namespace Js
445445
return scriptContext->GetLibrary()->GetUndefined();
446446
}
447447

448-
RecyclableObject *func = VarTo<RecyclableObject>(args.Values[1]);
448+
// TODO: This is marked volatile due to MSVC codegen bug in x86_test_pogo builds. Remove when the bug is fixed
449+
RecyclableObject *volatile func = VarTo<RecyclableObject>(args.Values[1]);
449450

450451
AssertOrFailFastMsg(func != scriptContext->GetLibrary()->GetUndefined(), "Trying to callInstanceFunction(undefined, ...)");
451452

0 commit comments

Comments
 (0)