Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Commit 187fd1e

Browse files
refactor(use-disclosure): update naming to emit methods
1 parent 8fe6960 commit 187fd1e

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/vue-composables/examples/use-disclosure-drawer.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<template>
2-
<c-button @click="onOpen">Open Drawer</c-button>
2+
<c-button @click="open">Open Drawer</c-button>
33
<c-drawer placement="right" v-model="isOpen">
44
<c-drawer-overlay />
55
<c-drawer-content>
66
<c-drawer-header borderBottomWidth="1px">Basic Drawer</c-drawer-header>
7-
<c-drawer-close-button @click="onClose" />
7+
<c-drawer-close-button @click="close" />
88
<c-drawer-body>
99
<p>Some contents...</p>
1010
<p>Some contents...</p>
@@ -16,5 +16,5 @@
1616
<script lang="ts" setup>
1717
import { useDisclosure } from "../src/use-disclosure"
1818
19-
const { onOpen, onClose, isOpen } = useDisclosure()
19+
const { open, close, isOpen } = useDisclosure()
2020
</script>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<c-v-stack gap="4">
3-
<c-button @click="onToggle">This is a button</c-button>
3+
<c-button @click="toggle">This is a button</c-button>
44
<c-center h="4">
55
<c-box :hidden="!isOpen">Toggled On with onToggle!</c-box>
66
</c-center>
@@ -9,5 +9,5 @@
99
<script setup lang="ts">
1010
import { useDisclosure } from "../src/use-disclosure"
1111
12-
const { onToggle, isOpen } = useDisclosure()
12+
const { toggle, isOpen } = useDisclosure()
1313
</script>

packages/vue-composables/src/use-disclosure.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,21 @@ export function useDisclosure(props: UseDisclosureProps = {}) {
3333
const uid = useId()
3434
const id = computed(() => idProp ?? `disclosure-${uid.value}`)
3535

36-
const onClose = () => {
36+
const close = () => {
3737
if (!isControlled) {
3838
isOpenState.value = false
3939
}
4040
handleClose?.()
4141
}
4242

43-
const onOpen = () => {
43+
const open = () => {
4444
if (!isControlled) {
4545
isOpenState.value = true
4646
}
4747
handleOpen?.()
4848
}
4949

50-
const onToggle = () => (isOpen.value ? onClose() : onOpen())
50+
const toggle = () => (isOpen.value ? close() : open())
5151

5252
/**
5353
* Computed object containing the HTML attributes for the button that
@@ -62,7 +62,7 @@ export function useDisclosure(props: UseDisclosureProps = {}) {
6262
"aria-expanded": isOpen.value,
6363
"aria-controls": id.value,
6464
onClick() {
65-
onToggle()
65+
toggle()
6666
},
6767
}))
6868

@@ -85,9 +85,9 @@ export function useDisclosure(props: UseDisclosureProps = {}) {
8585

8686
return {
8787
isOpen,
88-
onOpen,
89-
onClose,
90-
onToggle,
88+
open,
89+
close,
90+
toggle,
9191
isControlled,
9292
buttonProps,
9393
disclosureProps,

0 commit comments

Comments
 (0)