Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Commit 1a78d56

Browse files
committed
fix(checkbox): improve production build for function slots
1 parent 43bcb43 commit 1a78d56

File tree

4 files changed

+59
-4
lines changed

4 files changed

+59
-4
lines changed

.changeset/slow-tables-compare.md

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
---
2+
"@chakra-ui/vue-anatomy": minor
3+
"@chakra-ui/c-accordion": minor
4+
"@chakra-ui/c-alert": minor
5+
"@chakra-ui/c-avatar": minor
6+
"@chakra-ui/c-breadcrumb": minor
7+
"@chakra-ui/c-button": minor
8+
"@chakra-ui/c-checkbox": minor
9+
"@chakra-ui/c-close-button": minor
10+
"@chakra-ui/c-code": minor
11+
"@chakra-ui/c-color-mode": minor
12+
"@chakra-ui/c-flex": minor
13+
"@chakra-ui/c-focus-lock": minor
14+
"@chakra-ui/c-form-control": minor
15+
"@chakra-ui/c-icon": minor
16+
"@chakra-ui/c-image": minor
17+
"@chakra-ui/c-input": minor
18+
"@chakra-ui/c-media-query": minor
19+
"@chakra-ui/c-modal": minor
20+
"@chakra-ui/c-motion": minor
21+
"@chakra-ui/c-pin-input": minor
22+
"@chakra-ui/c-popper": minor
23+
"@chakra-ui/c-portal": minor
24+
"@chakra-ui/c-reset": minor
25+
"@chakra-ui/c-scroll-lock": minor
26+
"@chakra-ui/c-skip-nav": minor
27+
"@chakra-ui/c-spinner": minor
28+
"@chakra-ui/c-tag": minor
29+
"@chakra-ui/c-theme-provider": minor
30+
"@chakra-ui/c-visually-hidden": minor
31+
"@chakra-ui/vue-next": minor
32+
"@chakra-ui/vue-layout": minor
33+
"@chakra-ui/nuxt-next": minor
34+
"@chakra-ui/vue-styled": minor
35+
"@chakra-ui/vue-system": minor
36+
"@chakra-ui/vue-test-utils": minor
37+
"@chakra-ui/vue-theme": minor
38+
"@chakra-ui/vue-theme-tools": minor
39+
"@chakra-ui/vue-utils": minor
40+
"@chakra-ui/vue-a11y": minor
41+
"@chakra-ui/vue-composables": minor
42+
"@chakra-ui/vue-auto-import": minor
43+
"@chakra-ui/vue-docs": minor
44+
---
45+
46+
Create Media Query, Avatar, Counter and Checkbox Components"

components.d.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*
77
* This is a generated file. Do not edit it's contents.
88
*
9-
* This file was generated on 2022-10-06T19:08:38.068Z
9+
* This file was generated on 2022-12-11T15:07:27.518Z
1010
*/
1111

1212
import { ChakraProps, chakra } from "@chakra-ui/vue-system"
@@ -86,6 +86,8 @@ declare module "@vue/runtime-core" {
8686
CFormLabel: typeof import("@chakra-ui/vue-next")["CFormLabel"]
8787
CRequiredIndicator: typeof import("@chakra-ui/vue-next")["CRequiredIndicator"]
8888
CIcon: typeof import("@chakra-ui/vue-next")["CIcon"]
89+
CImage: typeof import("@chakra-ui/vue-next")["CImage"]
90+
CImg: typeof import("@chakra-ui/vue-next")["CImg"]
8991
CInput: typeof import("@chakra-ui/vue-next")["CInput"]
9092
CInputAddon: typeof import("@chakra-ui/vue-next")["CInputAddon"]
9193
CInputGroup: typeof import("@chakra-ui/vue-next")["CInputGroup"]
@@ -146,6 +148,7 @@ declare module "@vue/runtime-core" {
146148
CCollapse: typeof import("@chakra-ui/vue-next")["CCollapse"]
147149
CMotion: typeof import("@chakra-ui/vue-next")["CMotion"]
148150
CPinInput: typeof import("@chakra-ui/vue-next")["CPinInput"]
151+
CPinInputClearButton: typeof import("@chakra-ui/vue-next")["CPinInputClearButton"]
149152
CPinInputField: typeof import("@chakra-ui/vue-next")["CPinInputField"]
150153
CPortal: typeof import("@chakra-ui/vue-next")["CPortal"]
151154
CSkipNavContent: typeof import("@chakra-ui/vue-next")["CSkipNavContent"]

packages/c-checkbox/src/checkbox-icon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export const CheckboxIcon = defineComponent(
158158

159159
return () => (
160160
<CCheckboxTransition open={props.isChecked || props.isIndeterminate}>
161-
{() => <IconEl.value {...attrs} />}
161+
<IconEl.value {...attrs} />
162162
</CCheckboxTransition>
163163
)
164164
}

packages/c-checkbox/src/checkbox.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ const CCheckboxControl = chakra("span", {
6262
},
6363
})
6464

65+
console.log("CCheckboxControl", CCheckboxControl)
66+
6567
const CLabel = chakra("label", {
6668
baseStyle: {
6769
cursor: "pointer",
@@ -176,7 +178,9 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
176178
},
177179
emits: ["change", "update:modelValue"],
178180
setup(props, { slots, attrs, emit }) {
179-
const group = useCheckboxGroupContext(computed(() => ({} as unknown)))
181+
const group = useCheckboxGroupContext(
182+
computed(() => ({} as CheckboxGroupContext))
183+
)
180184
const ownProps = computed(() => omitThemingProps(props))
181185
const mergedProps = computed(() => mergeWith({}, group.value, props, attrs))
182186
const styles = useMultiStyleConfig("Checkbox", mergedProps)
@@ -314,6 +318,8 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
314318
const children = getValidChildren(slots)
315319
const hasChildren = children.length > 0
316320

321+
console.log("clonedIcon", clonedIcon)
322+
317323
return (
318324
<chakra.div
319325
sx={{
@@ -334,7 +340,7 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
334340
__css={styles.value.control}
335341
{...api.value.controlProps}
336342
>
337-
{clonedIcon.value}
343+
{() => clonedIcon.value}
338344
</CCheckboxControl>
339345
{hasChildren && (
340346
<chakra.span

0 commit comments

Comments
 (0)