fix: account for escape hatch

Author: anubra266

plugin/src/rules/no-important.ts

@@ -1,6 +1,7 @@
 import { isPandaAttribute, isPandaProp } from '../utils/helpers'
 import { type Rule, createRule } from '../utils'
 import { isIdentifier, isJSXExpressionContainer, isLiteral, isTemplateLiteral, type Node } from '../utils/nodes'
+import { getArbitraryValue } from '@pandacss/shared'
 
 // Check if the string ends with '!' with optional whitespace before it
 const exclamationRegex = /\s*!$/
@@ -29,8 +30,9 @@ const rule: Rule = createRule({
   create(context) {
     const removeQuotes = ([start, end]: readonly [number, number]) => [start + 1, end - 1] as const
 
-    const hasImportantKeyword = (value?: string) => {
-      if (!value) return false
+    const hasImportantKeyword = (_value?: string) => {
+      if (!_value) return false
+      const value = getArbitraryValue(_value)
       return exclamationRegex.test(value) || importantRegex.test(value)
     }
 

plugin/src/rules/no-unsafe-token-fn-usage.ts

@@ -9,6 +9,7 @@ import {
   isTemplateLiteral,
   type Node,
 } from '../utils/nodes'
+import { getArbitraryValue } from '@pandacss/shared'
 
 export const RULE_NAME = 'no-unsafe-token-fn-usage'
 
@@ -43,10 +44,10 @@ const rule: Rule = createRule({
       const value = node.arguments[0]
 
       if (isLiteral(value)) {
-        sendReport(node, tokenWrap(value.value?.toString()))
+        sendReport(node, tokenWrap(getArbitraryValue(value.value?.toString() ?? '')))
       }
       if (isTemplateLiteral(value)) {
-        sendReport(node, tokenWrap(value.quasis[0].value.raw))
+        sendReport(node, tokenWrap(getArbitraryValue(value.quasis[0].value.raw)))
       }
     }
 
@@ -59,20 +60,20 @@ const rule: Rule = createRule({
 
     const handleLiteral = (node: Node) => {
       if (!isLiteral(node)) return
-      if (isCompositeValue(node.value?.toString())) return
+      const value = getArbitraryValue(node.value?.toString() ?? '')
+      if (isCompositeValue(value)) return
 
-      sendReport(node)
+      sendReport(node, value)
     }
 
     const handleTemplateLiteral = (node: Node) => {
       if (!isTemplateLiteral(node)) return
       if (node.expressions.length > 0) return
 
-      sendReport(node, node.quasis[0].value.raw)
+      sendReport(node, getArbitraryValue(node.quasis[0].value.raw))
     }
 
-    const sendReport = (node: any, _value?: string) => {
-      const value = _value ?? node.value?.toString()
+    const sendReport = (node: any, value: string) => {
       const tkImports = extractTokens(value)
       const token = tkImports[0].replace(/^[^.]*\./, '')
 

plugin/tests/no-important.test.ts

@@ -52,7 +52,7 @@ function App(){
 import { Circle } from './panda/jsx';
 
 function App(){
-  return  <Circle _hover={{ position: 'absolute !' }} />;
+  return  <Circle _hover={{ position: '[absolute!]' }} />;
 }`,
   },
 ]

plugin/tests/no-unsafe-token-fn-usage.test.ts

@@ -55,7 +55,7 @@ const styles = css({ bg: token('colors.red.300') })`,
   import { Circle } from './panda/jsx';
 
   function App(){
-    return  <Circle margin='{sizes.4}' />;
+    return  <Circle margin='[{sizes.4}]' />;
   }`,
   },
 ]