Skip to content

Commit 01d72ad

Browse files
jmaestreeJavier Maestre
andauthored
feat: update groupInvalid selector for better invalid state handling (#3166)
feat: update groupInvalid selector according to other group selector implementations Co-authored-by: Javier Maestre <[email protected]>
1 parent 4c4247b commit 01d72ad

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

.changeset/long-pandas-press.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@pandacss/preset-base': minor
3+
'@pandacss/studio': minor
4+
---
5+
6+
update groupInvalid selector according to other group selector implementations

packages/preset-base/src/conditions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const conditions = {
5656
groupDisabled: '.group:is(:disabled, [disabled], [data-disabled]) &',
5757
groupChecked: '.group:is(:checked, [data-checked], [aria-checked=true], [data-state="checked"]) &',
5858
groupExpanded: '.group:is([aria-expanded=true], [data-expanded], [data-state="expanded"]) &',
59-
groupInvalid: '.group:invalid &',
59+
groupInvalid: '.group:is(:invalid, [data-invalid]) &',
6060

6161
indeterminate: '&:is(:indeterminate, [data-indeterminate], [aria-checked=mixed], [data-state="indeterminate"])',
6262
required: '&:is(:required, [data-required], [aria-required=true])',

packages/studio/styled-system/types/conditions.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export interface Conditions {
106106
"_groupChecked": string
107107
/** `.group:is([aria-expanded=true], [data-expanded], [data-state="expanded"]) &` */
108108
"_groupExpanded": string
109-
/** `.group:invalid &` */
109+
/** `.group:is(:invalid, [data-invalid]) &` */
110110
"_groupInvalid": string
111111
/** `&:is(:indeterminate, [data-indeterminate], [aria-checked=mixed], [data-state="indeterminate"])` */
112112
"_indeterminate": string

website/pages/docs/concepts/conditional-styles.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ Here's a list of all the condition shortcuts you can use in Panda:
568568
| \_groupDisabled | `.group:is(:disabled, [disabled], [data-disabled]) &` |
569569
| \_groupChecked | `.group:is(:checked, [data-checked], [aria-checked=true]) &` |
570570
| \_groupExpanded | `.group:is([aria-expanded=true], [data-expanded]) &` |
571-
| \_groupInvalid | `.group:invalid &` |
571+
| \_groupInvalid | `.group:is(:invalid, [data-invalid]) &` |
572572
| \_indeterminate | `&:is(:indeterminate, [data-indeterminate], [aria-checked=mixed])` |
573573
| \_required | `&:is(:required, [data-required], [aria-required=true])` |
574574
| \_valid | `&:is(:valid, [data-valid])` |

0 commit comments

Comments
 (0)