fix(styled): defaultProps override

Author: segunadebayo

.changeset/fix-children-override.md

@@ -0,0 +1,9 @@
+---
+'@pandacss/generator': patch
+---
+
+Fix issue where specifying `defaultProps.children` in the `styled` or `createStyleContext` factories makes it impossible
+to override children.
+
+The fix ensures that explicitly passed children take precedence over default children in React, Preact, and Qwik JSX
+factories.

packages/generator/src/artifacts/preact-jsx/jsx.ts

@@ -71,7 +71,7 @@ export function generatePreactJsxFactory(ctx: Context) {
           ...normalizeHTMLProps(htmlProps),
           ref,
           className: classes()
-        }, combinedProps.children ?? children)
+        }, children ?? combinedProps.children)
       })
 
       const name = getDisplayName(__base__)

packages/generator/src/artifacts/qwik-jsx/jsx.ts

@@ -68,7 +68,7 @@ export function generateQwikJsxFactory(ctx: Context) {
           ...elementProps,
           ...normalizeHTMLProps(htmlProps),
           class: classes(),
-        }, combinedProps.children ?? children)
+        }, children ?? combinedProps.children)
       }
 
       const name = getDisplayName(__base__)

packages/generator/src/artifacts/react-jsx/jsx.ts

@@ -68,7 +68,7 @@ export function generateReactJsxFactory(ctx: Context) {
           ...elementProps,
           ...normalizeHTMLProps(htmlProps),
           className: classes(),
-        }, combinedProps.children ?? children)
+        }, children ?? combinedProps.children)
       })
 
       const name = getDisplayName(__base__)

packages/studio/styled-system/jsx/factory.mjs

@@ -57,7 +57,7 @@ function styledFn(Dynamic, configOrCva = {}, options = {}) {
       ...elementProps,
       ...normalizeHTMLProps(htmlProps),
       className: classes(),
-    }, combinedProps.children ?? children)
+    }, children ?? combinedProps.children)
   })
 
   const name = getDisplayName(__base__)