refactor: recipe jsx inference

Author: segunadebayo

.changeset/clever-breads-fly.md

@@ -0,0 +1,6 @@
+---
+'@pandacss/core': patch
+---
+
+JSX: Always track the `<component>.Root` for recipe variant props. This is a generally resilient default and prevents
+the need for manual jsx hints.

packages/core/src/recipes.ts

@@ -127,7 +127,7 @@ export class Recipes {
 
     const ROOT_SLOT = 'root'
 
-    if ('slots' in recipe && recipe.slots.includes(ROOT_SLOT)) {
+    if (Recipes.isSlotRecipeConfig(recipe) && recipe.slots.includes(ROOT_SLOT)) {
       const jsxRootName = capitalize(ROOT_SLOT)
       const rootNames: string[] = [`${capitalized}.${jsxRootName}`, `${capitalized}${jsxRootName}`]
       jsx.push(...rootNames)

packages/studio/styled-system/types/global.d.ts

@@ -10,7 +10,7 @@ import type { CompositionStyles } from './composition';
 declare module '@pandacss/dev' {
   export function defineRecipe<V extends RecipeVariantRecord>(config: RecipeConfig<V>): Panda.RecipeConfig
   export function defineSlotRecipe<S extends string, V extends SlotRecipeVariantRecord<S>>(config: SlotRecipeConfig<S, V>): Panda.SlotRecipeConfig
-  export function defineStyles(definition: SystemStyleObject): SystemStyleObject
+  export function defineStyles<T extends SystemStyleObject>(definition: T): T
   export function defineGlobalStyles(definition: GlobalStyleObject): Panda.GlobalStyleObject
   export function defineTextStyles(definition: CompositionStyles['textStyles']): Panda.TextStyles
   export function defineAnimationStyles(definition: CompositionStyles['animationStyles']): Panda.AnimationStyles

packages/studio/styled-system/types/jsx.d.ts

@@ -34,7 +34,7 @@ interface RecipeFn {
   __type: any
 }
 
-interface JsxFactoryOptions<TProps extends Dict> {
+export interface JsxFactoryOptions<TProps extends Dict> {
   dataAttr?: boolean
   defaultProps?: Partial<TProps>
   shouldForwardProp?: (prop: string, variantKeys: string[]) => boolean