Allow arbitrary breakpoint values for hideBelow
and hideFrom
#1523
hobbescodes
started this conversation in
Ideas
Replies: 1 comment
-
I agree |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
So in its current state,
hideBelow
andhideFrom
seem to only accept breakpoint tokens (i.e.sm
,md
,lg
, etc). This is great for consistent design with what is defined in your config, however, there are issues that arise when having multiple components rendered in the same scope that use bothhideBelow
andhideFrom
. The issue is thathideBelow
andhideFrom
are both inclusive on the designated breakpoint, therefore, at the exact point of said breakpoint, components will always be hidden. See: Minimal reproducible example.Proposed solution(s):
Redefine
hideBelow
to be noninclusive on provided breakpoints. The term "below" implies that it should not be hidden at said breakpoint, but rather just hidden up to said breakpoint.If solution 1 is not conceivable (or possibly even it is), I would propose allowing arbitrary values (i.e.
700px
) to be passed tohideBelow
andhideFrom
. That way developers have more concise control over intended outcomes when using eitherhideBelow
orhideFrom
.Beta Was this translation helpful? Give feedback.
All reactions