Skip to content

Commit 3dbfe4a

Browse files
committed
fix: avoid context change in root exit
1 parent ed266df commit 3dbfe4a

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@zag-js/collapsible": patch
3+
"@zag-js/presence": patch
4+
"@zag-js/tour": patch
5+
---
6+
7+
Fix machines setting reactive state in exit actions.
8+
9+
> **Affected machines:** Presence, Collapsible, and Tour.

packages/machines/collapsible/src/collapsible.machine.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export const machine = createMachine<CollapsibleSchema>({
4343
})
4444
},
4545

46-
exit: ["clearInitial", "cleanupNode"],
46+
exit: ["cleanupNode"],
4747

4848
states: {
4949
closed: {

packages/machines/presence/src/presence.machine.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const machine = createMachine<PresenceSchema>({
3030
}
3131
},
3232

33-
exit: ["clearInitial", "cleanupNode"],
33+
exit: ["cleanupNode"],
3434

3535
watch({ track, prop, send }) {
3636
track([() => prop("present")], () => {
@@ -91,10 +91,6 @@ export const machine = createMachine<PresenceSchema>({
9191
})
9292
},
9393

94-
clearInitial: ({ context }) => {
95-
context.set("initial", false)
96-
},
97-
9894
invokeOnExitComplete: ({ prop, refs }) => {
9995
prop("onExitComplete")?.()
10096

packages/machines/tour/src/tour.machine.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -561,17 +561,14 @@ class StepManager {
561561
* Use when completely tearing down the tour or transitioning between steps.
562562
*/
563563
cleanupAll() {
564-
const { refs, context } = this.params
564+
const { refs } = this.params
565565

566566
refs.get("_targetCleanup")?.()
567567
refs.set("_targetCleanup", undefined)
568568
refs.set("_prevTarget", undefined)
569569

570570
refs.get("_effectCleanup")?.()
571571
refs.set("_effectCleanup", undefined)
572-
573-
// Clear resolved target to prevent stale DOM references
574-
context.set("resolvedTarget", null)
575572
}
576573

577574
/**

0 commit comments

Comments
 (0)