test: refactor

Author: segunadebayo

packages/frameworks/react/tests/machine.test.ts

@@ -449,3 +449,173 @@ describe("basic", () => {
     vi.useRealTimers()
   })
 })
+
+describe("edge cases", () => {
+  test("reactive props updates", async () => {
+    const actionSpy = vi.fn()
+
+    const machine = createMachine<any>({
+      props({ props }) {
+        return { max: props.max || 0 }
+      },
+      initialState() {
+        return "test"
+      },
+      context({ bindable }) {
+        return {
+          count: bindable(() => ({ defaultValue: 0 })),
+        }
+      },
+      states: {
+        test: {
+          on: {
+            INCREMENT: {
+              actions: ["increment"],
+            },
+            CHECK: {
+              guard: ({ prop, context }: any) => context.get("count") < prop("max"),
+              actions: ["allowAction"],
+            },
+          },
+        },
+      },
+      implementations: {
+        actions: {
+          allowAction: actionSpy,
+          increment: ({ context }) => context.set("count", context.get("count") + 1),
+        },
+      },
+    })
+
+    const { result } = renderHook(() => useMachine(machine, { max: 5 }))
+
+    // Increment count to 3
+    await act(async () => result.current.send({ type: "INCREMENT" }))
+    await act(async () => result.current.send({ type: "INCREMENT" }))
+    await act(async () => result.current.send({ type: "INCREMENT" }))
+
+    // max is 5, count is 3, should allow action
+    await act(async () => result.current.send({ type: "CHECK" }))
+    expect(actionSpy).toHaveBeenCalledTimes(1)
+  })
+
+  test("state.matches() helper", async () => {
+    const machine = createMachine<any>({
+      initialState() {
+        return "idle"
+      },
+      states: {
+        idle: {
+          on: {
+            START: { target: "loading" },
+          },
+        },
+        loading: {
+          on: {
+            SUCCESS: { target: "success" },
+            ERROR: { target: "error" },
+          },
+        },
+        success: {},
+        error: {},
+      },
+    })
+
+    const { result, send } = renderMachine(machine)
+
+    expect(result.current.state.matches("idle")).toBe(true)
+    expect(result.current.state.matches("idle", "loading")).toBe(true)
+    expect(result.current.state.matches("loading", "success")).toBe(false)
+
+    await send({ type: "START" })
+    expect(result.current.state.matches("loading")).toBe(true)
+    expect(result.current.state.matches("idle", "loading", "error")).toBe(true)
+
+    await send({ type: "SUCCESS" })
+    expect(result.current.state.matches("success", "error")).toBe(true)
+    expect(result.current.state.matches("idle", "loading")).toBe(false)
+  })
+
+  test("same-state transitions with actions", async () => {
+    const actionSpy = vi.fn()
+
+    const machine = createMachine<any>({
+      initialState() {
+        return "active"
+      },
+      states: {
+        active: {
+          on: {
+            PING: {
+              target: "active",
+              actions: ["onPing"],
+            },
+          },
+        },
+      },
+      implementations: {
+        actions: {
+          onPing: actionSpy,
+        },
+      },
+    })
+
+    const { result, send } = renderMachine(machine)
+
+    expect(result.current.state.get()).toBe("active")
+
+    await send({ type: "PING" })
+    expect(result.current.state.get()).toBe("active")
+    expect(actionSpy).toHaveBeenCalledTimes(1)
+
+    await send({ type: "PING" })
+    expect(result.current.state.get()).toBe("active")
+    expect(actionSpy).toHaveBeenCalledTimes(2)
+  })
+
+  test("event previous/current tracking", async () => {
+    let capturedPrevious: any = null
+    let capturedCurrent: any = null
+
+    const machine = createMachine<any>({
+      initialState() {
+        return "test"
+      },
+      states: {
+        test: {
+          on: {
+            FIRST: {
+              target: "second",
+            },
+            SECOND: {
+              actions: ["captureEvents"],
+            },
+          },
+        },
+        second: {
+          on: {
+            THIRD: {
+              actions: ["captureEvents"],
+            },
+          },
+        },
+      },
+      implementations: {
+        actions: {
+          captureEvents({ event }) {
+            capturedPrevious = event.previous()
+            capturedCurrent = event.current()
+          },
+        },
+      },
+    })
+
+    const { send } = renderMachine(machine)
+
+    await send({ type: "FIRST", data: "first-data" })
+    await send({ type: "THIRD", data: "third-data" })
+
+    expect(capturedCurrent).toMatchObject({ type: "THIRD", data: "third-data" })
+    expect(capturedPrevious).toMatchObject({ type: "FIRST", data: "first-data" })
+  })
+})

packages/frameworks/react/vite.config.ts

@@ -1,6 +1,8 @@
 import { defineConfig } from "vitest/config"
+import react from "@vitejs/plugin-react"
 
 export default defineConfig({
+  plugins: [react()],
   test: {
     retry: 2,
     globals: true,

packages/frameworks/solid/package.json

@@ -26,18 +26,19 @@
   },
   "dependencies": {
     "@solid-primitives/keyed": "^1.5.2",
-    "@zag-js/utils": "workspace:*",
     "@zag-js/core": "workspace:*",
     "@zag-js/store": "workspace:*",
-    "@zag-js/types": "workspace:*"
+    "@zag-js/types": "workspace:*",
+    "@zag-js/utils": "workspace:*"
   },
   "devDependencies": {
-    "@types/jsdom": "^21.1.7",
-    "solid-js": "1.9.9",
-    "clean-package": "2.2.0",
     "@solidjs/testing-library": "^0.8.10",
     "@testing-library/jest-dom": "^6.8.0",
-    "jsdom": "^27.0.0"
+    "@types/jsdom": "^21.1.7",
+    "clean-package": "2.2.0",
+    "jsdom": "^27.0.0",
+    "solid-js": "1.9.9",
+    "vite-plugin-solid": "^2.11.9"
   },
   "peerDependencies": {
     "solid-js": ">=1.1.3"

packages/frameworks/solid/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "extends": "../../../tsconfig.json",
-  "include": ["src", "tests"],
+  "include": ["src", "tests", "vite.config.ts"],
   "compilerOptions": {
     "tsBuildInfoFile": "node_modules/.cache/.tsbuildinfo"
   }

packages/frameworks/solid/vite.config.ts

@@ -1,11 +1,16 @@
 import { defineConfig } from "vitest/config"
+import solidPlugin from "vite-plugin-solid"
 
 export default defineConfig({
+  plugins: [solidPlugin()],
   test: {
     retry: 2,
     globals: true,
     environment: "jsdom",
     css: false,
     setupFiles: "./vitest.setup.ts",
   },
+  resolve: {
+    conditions: ["development", "browser"],
+  },
 })

pnpm-lock.yaml

@@ -12,7 +12,7 @@
     "lib": ["dom", "dom.iterable", "esnext"],
     "target": "esnext",
     "module": "esnext",
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "noImplicitReturns": false,
     "resolveJsonModule": true,
     "exactOptionalPropertyTypes": true,