Removes voiceover related temporary changes (oppia#22511)

* Removes voiceover related temporary changes

* Adds feature flag to deprecated section

* Removes voiceover jobs from registry

* Fixes mypy check

* Fixes lint checks

* Removes non required files

* Removes instances of removed file

* Fixes lint issues

* Fixes frontend tests

* Fixes acceptance tests

* Fixes lint tests

Author: Nik-09

core/controllers/voiceover.py

@@ -115,96 +115,6 @@ def put(self) -> None:
         self.render_json(self.values)
 
 
-class PutVoiceArtistMetadataHandlerNormalizedPayloadDict(TypedDict):
-    """Dict representation of VoiceArtistMetadataHandler's normalized_payload
-    dictionary.
-    """
-
-    voice_artist_id: str
-    language_code: str
-    language_accent_code: str
-
-
-class VoiceArtistMetadataHandler(
-    base.BaseHandler[
-        PutVoiceArtistMetadataHandlerNormalizedPayloadDict, Dict[str, str]
-    ]
-):
-    """Handler class to manage voice artist data for the voiceover admin page."""
-
-    GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON
-    URL_PATH_ARGS_SCHEMAS: Dict[str, str] = {}
-    HANDLER_ARGS_SCHEMAS = {
-        'GET': {},
-        'PUT': {
-            'voice_artist_id': {'schema': {'type': 'basestring'}},
-            'language_code': {'schema': {'type': 'basestring'}},
-            'language_accent_code': {'schema': {'type': 'basestring'}},
-        },
-    }
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def get(self) -> None:
-        """Retrieves voice artist data for the voiceover admin page."""
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping()
-        )
-        voice_artist_id_to_voice_artist_name = (
-            voiceover_services.get_voice_artist_ids_to_voice_artist_names()
-        )
-
-        self.values.update(
-            {
-                'voice_artist_id_to_language_mapping': voice_artist_id_to_language_mapping,
-                'voice_artist_id_to_voice_artist_name': voice_artist_id_to_voice_artist_name,
-            }
-        )
-        self.render_json(self.values)
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def put(self) -> None:
-        """Updates voice artist data from the voiceover admin page."""
-        assert self.normalized_payload is not None
-        voice_artist_id = self.normalized_payload['voice_artist_id']
-        language_code = self.normalized_payload['language_code']
-        language_accent_code = self.normalized_payload['language_accent_code']
-
-        voiceover_services.update_voice_artist_language_mapping(
-            voice_artist_id, language_code, language_accent_code
-        )
-        self.render_json(self.values)
-
-
-class GetSampleVoiceoversForGivenVoiceArtistHandler(
-    base.BaseHandler[Dict[str, str], Dict[str, str]]
-):
-    """Handler class to get sample contributed voiceovers of a voice artist in
-    a given language.
-    """
-
-    GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON
-    URL_PATH_ARGS_SCHEMAS = {
-        'voice_artist_id': {'schema': {'type': 'basestring'}},
-        'language_code': {'schema': {'type': 'basestring'}},
-    }
-    HANDLER_ARGS_SCHEMAS: Dict[str, Dict[str, str]] = {'GET': {}}
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def get(self, voice_artist_id: str, language_code: str) -> None:
-        exploration_id_to_filenames = (
-            voiceover_services.get_voiceover_filenames(
-                voice_artist_id=voice_artist_id, language_code=language_code
-            )
-        )
-
-        self.values.update(
-            {
-                'exploration_id_to_filenames': exploration_id_to_filenames,
-            }
-        )
-        self.render_json(self.values)
-
-
 class EntityVoiceoversBulkHandler(
     base.BaseHandler[Dict[str, str], Dict[str, str]]
 ):

core/controllers/voiceover_test.py

@@ -126,162 +126,6 @@ def test_invalid_language_accent_codes_mapping_raise_error(self) -> None:
         self.logout()
 
 
-class VoiceArtistMetadataHandlerTests(test_utils.GenericTestBase):
-    """The class validates functionality related to voice artist metadata model."""
-
-    def setUp(self) -> None:
-        super().setUp()
-        self.signup(self.VOICEOVER_ADMIN_EMAIL, self.VOICEOVER_ADMIN_USERNAME)
-        self.set_voiceover_admin([self.VOICEOVER_ADMIN_USERNAME])
-        auth_id = 'someUser'
-        self.voice_artist_username = 'username'
-        user_settings = user_services.create_new_user(
-            auth_id, 'user@example.com'
-        )
-        self.voice_artist_id = user_settings.user_id
-        user_services.set_username(
-            self.voice_artist_id, self.voice_artist_username
-        )
-
-        self.voiceover1: state_domain.VoiceoverDict = {
-            'filename': 'filename1.mp3',
-            'file_size_bytes': 3000,
-            'needs_update': False,
-            'duration_secs': 6.1,
-        }
-        self.voiceover2: state_domain.VoiceoverDict = {
-            'filename': 'filename2.mp3',
-            'file_size_bytes': 3500,
-            'needs_update': False,
-            'duration_secs': 5.9,
-        }
-        self.voiceover3: state_domain.VoiceoverDict = {
-            'filename': 'filename3.mp3',
-            'file_size_bytes': 3500,
-            'needs_update': False,
-            'duration_secs': 5.0,
-        }
-
-        self.language_code_to_accent: Dict[str, str] = {
-            'en': 'en-US',
-            'hi': 'hi-IN',
-        }
-
-        self.content_id_to_voiceovers_mapping: (
-            voiceover_domain.ContentIdToVoiceoverMappingType
-        ) = {
-            'content_1': {'en': (self.voice_artist_id, self.voiceover1)},
-            'content_2': {'hi': (self.voice_artist_id, self.voiceover2)},
-            'content_3': {'ar': (self.voice_artist_id, self.voiceover1)},
-        }
-
-        exploration_voice_artist_link_model = voiceover_services.create_exploration_voice_artists_link_model_instance(
-            exploration_id='exploration_id',
-            content_id_to_voiceovers_mapping=(
-                self.content_id_to_voiceovers_mapping
-            ),
-        )
-        exploration_voice_artist_link_model.put()
-
-        voiceover_services.update_voice_artist_metadata(
-            voice_artist_id=self.voice_artist_id,
-            language_code_to_accent=(self.language_code_to_accent),
-        )
-
-    def test_get_voice_artist_data_for_voiceover_admin_page(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-
-        expected_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {'en': 'en-US', 'hi': 'hi-IN', 'ar': ''}
-        }
-        expected_voice_artist_id_to_voice_artist_name = {
-            self.voice_artist_id: self.voice_artist_username
-        }
-        json_response = self.get_json(feconf.VOICE_ARTIST_METADATA_HANDLER)
-
-        self.assertDictEqual(
-            json_response['voice_artist_id_to_language_mapping'],
-            expected_voice_artist_id_to_language_mapping,
-        )
-        self.assertDictEqual(
-            json_response['voice_artist_id_to_voice_artist_name'],
-            expected_voice_artist_id_to_voice_artist_name,
-        )
-        self.logout()
-
-    def test_should_update_voice_artist_language_mapping(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-        csrf_token = self.get_new_csrf_token()
-
-        initial_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {'en': 'en-US', 'hi': 'hi-IN', 'ar': ''}
-        }
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping()
-        )
-
-        self.assertDictEqual(
-            voice_artist_id_to_language_mapping,
-            initial_voice_artist_id_to_language_mapping,
-        )
-
-        payload = {
-            'voice_artist_id': self.voice_artist_id,
-            'language_code': 'ar',
-            'language_accent_code': 'ar-EG',
-        }
-        self.put_json(
-            feconf.VOICE_ARTIST_METADATA_HANDLER, payload, csrf_token=csrf_token
-        )
-
-        final_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {'en': 'en-US', 'hi': 'hi-IN', 'ar': 'ar-EG'}
-        }
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping()
-        )
-
-        self.assertDictEqual(
-            voice_artist_id_to_language_mapping,
-            final_voice_artist_id_to_language_mapping,
-        )
-        self.logout()
-
-    def test_get_exp_id_to_filenames_for_given_voice_artist(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-
-        handler_url = '%s/%s/%s' % (
-            feconf.GET_SAMPLE_VOICEOVERS_FOR_VOICE_ARTIST,
-            self.voice_artist_id,
-            'en',
-        )
-
-        expected_exp_id_to_filenames = {'exploration_id': ['filename1.mp3']}
-
-        json_response = self.get_json(handler_url)
-
-        self.assertDictEqual(
-            json_response['exploration_id_to_filenames'],
-            expected_exp_id_to_filenames,
-        )
-
-        handler_url = '%s/%s/%s' % (
-            feconf.GET_SAMPLE_VOICEOVERS_FOR_VOICE_ARTIST,
-            self.voice_artist_id,
-            'hi',
-        )
-
-        expected_exp_id_to_filenames = {'exploration_id': ['filename2.mp3']}
-
-        json_response = self.get_json(handler_url)
-
-        self.assertDictEqual(
-            json_response['exploration_id_to_filenames'],
-            expected_exp_id_to_filenames,
-        )
-        self.logout()
-
-
 class EntityVoiceoversBulkHandlerTests(test_utils.GenericTestBase):
     """Test class to validate entity voiceovers bulk handler."""
 

core/domain/takeout_service_test.py

@@ -62,7 +62,6 @@
         suggestion_models,
         topic_models,
         user_models,
-        voiceover_models,
     )
 
 (
@@ -83,7 +82,6 @@
     suggestion_models,
     topic_models,
     user_models,
-    voiceover_models,
 ) = models.Registry.import_models(
     [
         models.Names.APP_FEEDBACK_REPORT,
@@ -103,7 +101,6 @@
         models.Names.SUGGESTION,
         models.Names.TOPIC,
         models.Names.USER,
-        models.Names.VOICEOVER,
     ]
 )
 
@@ -490,7 +487,6 @@ def set_up_non_trivial(self) -> None:
         20) Creates new BlogPostModel and BlogPostRightsModel.
         21) Creates a TranslationContributionStatsModel.
         22) Creates new LearnerGroupModel and LearnerGroupsUserModel.
-        23) Creates a VoiceArtistMetadataModel.
         """
         # Setup for UserStatsModel.
         user_models.UserStatsModel(
@@ -1061,13 +1057,6 @@ def set_up_non_trivial(self) -> None:
             id=self.USER_ID_1, parent_user_id=self.PROFILE_ID_1
         ).put()
 
-        language_code_to_accent: Dict[str, str] = {'en': 'en-US', 'hi': 'hi-IN'}
-        # Setup for VoiceArtistMetadataModel.
-        voiceover_models.VoiceArtistMetadataModel.create_model(
-            voice_artist_id=self.USER_ID_1,
-            language_code_to_accent=language_code_to_accent,
-        )
-
         # Set-up for AppFeedbackReportModel scrubbed by user.
         report_id = '%s.%s.%s' % (
             self.PLATFORM_ANDROID,
@@ -1334,7 +1323,6 @@ def test_export_data_for_full_user_trivial_is_correct(self) -> None:
         expected_blog_author_details: Dict[str, Dict[str, str]] = {}
         expected_learner_group_model_data: Dict[str, str] = {}
         expected_learner_grp_user_model_data: Dict[str, str] = {}
-        expected_voice_artist_data: Dict[str, str] = {}
 
         # Here we use type Any because this dictionary contains other
         # different types of dictionaries whose values can vary from int
@@ -1395,7 +1383,6 @@ def test_export_data_for_full_user_trivial_is_correct(self) -> None:
             'platform_parameter_snapshot_metadata': expected_platform_parameter_sm,
             'user_auth_details': expected_user_auth_details,
             'user_email_preferences': expected_user_email_preferences,
-            'voice_artist_metadata': expected_voice_artist_data,
         }
 
         # Perform export and compare.
@@ -2251,10 +2238,6 @@ def test_export_data_for_full_user_nontrivial_is_correct(self) -> None:
         expected_translation_coordinator_stats_data = {
             'coordinated_language_ids': ['es', 'hi']
         }
-        expected_language_code_to_accent: Dict[str, str] = {
-            'en': 'en-US',
-            'hi': 'hi-IN',
-        }
         expected_user_data = {
             'user_stats': expected_stats_data,
             'user_group': expected_user_group_data,
@@ -2310,7 +2293,6 @@ def test_export_data_for_full_user_nontrivial_is_correct(self) -> None:
             'blog_post': expected_blog_post_data,
             'blog_post_rights': expected_blog_post_rights,
             'blog_author_details': expected_blog_author_details,
-            'voice_artist_metadata': expected_language_code_to_accent,
         }
 
         with utils.open_file(