Skip to content

Commit 9feb8fa

Browse files
authored
Fix oppia#21987: Resolve mobile thumbnail modal glitch issue in blog post editor. (oppia#22036)
* resolve mobile UI glitch in blog post thumbnail upload * resolve mobile UI glitch in blog post thumbnail upload * resolve mobile UI glitch in blog post thumbnail upload * improve button UI * update mobile screenshots for blog editor error message on duplicate titles * adjust failureTrigger increment in puppeteer utils * update * update
1 parent 4f2da2d commit 9feb8fa

File tree

5 files changed

+52
-19
lines changed

5 files changed

+52
-19
lines changed

core/templates/components/forms/custom-forms-directives/image-receiver.component.html

Lines changed: 37 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
border-radius: 2px;
9393
bottom: 6px;
9494
cursor: pointer;
95-
display: inline;
95+
display: inline-block;
9696
font-size: 16px;
9797
font-weight: normal;
9898
padding: 4px 8px;
@@ -126,7 +126,7 @@
126126
.image-receiver-error-message {
127127
color: red;
128128
display: inline-block;
129-
font-size: 16;
129+
font-size: 16px;
130130
padding: 4px;
131131
}
132132

@@ -157,38 +157,59 @@
157157
width: 100%;
158158
}
159159

160-
@media(max-width:768px) {
160+
@media (max-width: 768px) {
161161
.mat-icon {
162162
font-size: 30px;
163163
height: 30px;
164164
width: 30px;
165165
}
166166

167-
.font-weight-light {
168-
font-size: 12px;
169-
font-weight: 300 !important;
170-
}
171-
172167
.image-receiver-license-warning {
173-
bottom: 50px;
168+
bottom: auto;
169+
left: auto;
170+
margin: 10px auto;
171+
padding: 8px;
172+
position: relative;
173+
right: auto;
174+
width: calc(100% - 20px);
174175
}
175176

176177
.image-receiver-drop-area {
177-
padding-top: 8px;
178-
text-align: left;
178+
align-items: center;
179+
display: flex;
180+
flex-direction: column;
181+
height: auto;
182+
justify-content: flex-start;
183+
min-height: 320px;
184+
padding: 15px 10px;
179185
}
180186

181-
label.image-receiver-upload-label-button {
182-
left: 8px;
183-
right: auto;
187+
.image-receiver-text {
188+
font-size: 14px;
189+
margin: 10px 0;
184190
}
185191

186-
.image-receiver-drop-area.image-receiver-is-narrow {
187-
height: 35px;
192+
.image-upload-instructions {
193+
padding-left: 15px;
194+
}
195+
196+
.image-upload-instructions li {
197+
margin-bottom: 3px;
198+
}
199+
200+
label.image-receiver-upload-label-button {
201+
bottom: auto;
202+
display: block;
203+
margin: 10px auto;
204+
max-width: 200px;
205+
position: relative;
206+
right: auto;
207+
width: 80%;
188208
}
189209

190210
.image-receiver-error-message {
191211
font-size: 10px;
212+
margin: 5px 0;
192213
}
193214

194215
.image-receiver-error-message i {

core/templates/pages/blog-dashboard-page/modal-templates/upload-blog-post-thumbnail.component.html

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,20 @@
8989

9090
.narrow-image-uploader {
9191
padding-left: 0;
92-
padding-top: 10px
92+
padding-top: 10px;
9393
}
94-
}
9594

95+
.btn-secondary.e2e-test-photo-upload-cancel,
96+
.btn-success.e2e-test-photo-upload-submit {
97+
align-items: center;
98+
display: flex;
99+
font-size: 12px;
100+
height: 45px;
101+
justify-content: center;
102+
padding: 7px;
103+
text-align: center;
104+
white-space: nowrap;
105+
width: 130px;
106+
}
107+
}
96108
</style>
Loading
Loading

core/tests/puppeteer-acceptance-tests/utilities/common/puppeteer-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ export class BaseUser {
733733
} else {
734734
dirName = '/dev-mobile-screenshots';
735735
}
736-
failureTrigger += 0.042;
736+
failureTrigger += 0.048;
737737
if (await currentPage.$(backgroundBanner)) {
738738
failureTrigger += 0.0352;
739739
} else if (await currentPage.$(libraryBanner)) {

0 commit comments

Comments
 (0)