Skip to content

Commit d2bdeb5

Browse files
authored
Removes queue yaml from the codebase (oppia#22157)
* Removes queue yaml from the codebase * Adds code comment
1 parent 6b577ea commit d2bdeb5

File tree

4 files changed

+2
-41
lines changed

4 files changed

+2
-41
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@
264264
/app_dev.yaml @oppia/release-workflow-reviewers
265265
/cron.yaml @oppia/release-workflow-reviewers
266266
/index.yaml @oppia/release-workflow-reviewers
267-
/queue.yaml @oppia/release-workflow-reviewers
268267

269268

270269
# Global components and filters.

core/domain/taskqueue_services.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232

3333
platform_taskqueue_services = models.Registry.import_taskqueue_services()
3434

35-
36-
# NOTE: The following constants should match the queue names in queue.yaml.
35+
# NOTE: The following constants should match the queue names on the
36+
# Cloud Tasks UI.
3737
# Taskqueue for backing up state.
3838
QUEUE_NAME_BACKUPS: Final = 'backups'
3939
# Default queue for processing tasks (including MapReduce ones).

core/domain/taskqueue_services_test.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import datetime
2222

2323
from core import feconf
24-
from core import utils
2524
from core.domain import taskqueue_services
2625
from core.platform import models
2726
from core.tests import test_utils
@@ -132,28 +131,3 @@ def mock_create_http_task(
132131
with swap_create_http_task:
133132
taskqueue_services.enqueue_task(
134133
correct_url, correct_payload, 0)
135-
136-
def test_that_queue_names_are_in_sync_with_queue_yaml_file(self) -> None:
137-
"""Checks that all of the queues that are instantiated in the queue.yaml
138-
file has a corresponding QUEUE_NAME_* constant instantiated in
139-
taskqueue_services.
140-
"""
141-
queue_name_dict = {}
142-
# Parse the queue.yaml file for the correct queue names.
143-
with utils.open_file('queue.yaml', 'r') as f:
144-
lines = f.readlines()
145-
for line in lines:
146-
if 'name' in line:
147-
queue_name = line.split(':')[1]
148-
queue_name_dict[queue_name.strip()] = False
149-
150-
# Get all attributes of taskqueue_services using the dir function.
151-
attributes = dir(taskqueue_services)
152-
# Check if the queue names in the queue.yaml file exist as a queue
153-
# name in taskqueue_services.
154-
for attribute in attributes:
155-
if attribute.startswith('QUEUE_NAME_'):
156-
queue_name_dict[getattr(taskqueue_services, attribute)] = True
157-
158-
for queue_name, in_taskqueue_services in queue_name_dict.items():
159-
self.assertTrue(in_taskqueue_services)

queue.yaml

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)