Skip to content

Commit 9fc055d

Browse files
authored
Remove alpha dimension token & Add alpha radius token (#2540)
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> ## Summary <!-- Please brief explanation of the changes made --> Remove alpha dimension token & Add alpha radius token ## Details <!-- Please elaborate description of the changes --> - 스펙 변경에 따라 내부적으로만 alpha dimension 토큰은 디자인 토큰에서 제거했습니다. - alpha radius 토큰을 추가했습니다. - alpha button에서 사용하던 dimension 토큰을 radius로 변경했습니다. - 데스크에 dimension 토큰 몇 사용처가 있어서, 버전 업데이트할 때 유의해야합니다. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> No (alpha version) ## References <!-- Please list any other resources or points the reviewer should be aware of --> - Figma Variable 참고
1 parent a0959f5 commit 9fc055d

File tree

6 files changed

+76
-229
lines changed

6 files changed

+76
-229
lines changed

.changeset/flat-birds-relax.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@channel.io/bezier-tokens': patch
3+
---
4+
5+
The alpha version dimension token is removed. The alpha version radius token is added.

packages/bezier-react/src/components/AlphaButton/Button.module.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,11 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
177177
/* border-radius */
178178
&:where(.variant-primary, .variant-secondary, .variant-tertiary) {
179179
$border-radius-by-size: (
180-
xs: var(--alpha-dimension-6),
181-
s: var(--alpha-dimension-7),
182-
m: var(--alpha-dimension-10),
183-
l: var(--alpha-dimension-12),
184-
xl: var(--alpha-dimension-14),
180+
xs: var(--alpha-radius-6),
181+
s: var(--alpha-radius-7),
182+
m: var(--alpha-radius-10),
183+
l: var(--alpha-radius-12),
184+
xl: var(--alpha-radius-14),
185185
);
186186

187187
@each $size, $border-radius in $border-radius-by-size {

packages/bezier-react/src/components/AlphaIconButton/IconButton.module.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,11 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
159159
/* border-radius */
160160
&:where(.shape-rectangle) {
161161
$border-radius-by-size: (
162-
xs: var(--alpha-dimension-6),
163-
s: var(--alpha-dimension-7),
164-
m: var(--alpha-dimension-10),
165-
l: var(--alpha-dimension-12),
166-
xl: var(--alpha-dimension-14),
162+
xs: var(--alpha-radius-6),
163+
s: var(--alpha-radius-7),
164+
m: var(--alpha-radius-10),
165+
l: var(--alpha-radius-12),
166+
xl: var(--alpha-radius-14),
167167
);
168168

169169
@each $size, $border-radius in $border-radius-by-size {

packages/bezier-react/src/components/AlphaToggleButton/ToggleButton.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
}
3030

3131
&:where(.shape-rectangle) {
32-
border-radius: var(--alpha-dimension-10);
32+
border-radius: var(--alpha-radius-10);
3333
}
3434

3535
&:where(.shape-capsule) {

packages/bezier-tokens/src/alpha/global/dimension.json

Lines changed: 0 additions & 218 deletions
This file was deleted.
Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
{
2+
"radius": {
3+
"2": {
4+
"value": "2px",
5+
"type": "dimension"
6+
},
7+
"3": {
8+
"value": "3px",
9+
"type": "dimension"
10+
},
11+
"4": {
12+
"value": "4px",
13+
"type": "dimension"
14+
},
15+
"6": {
16+
"value": "6px",
17+
"type": "dimension"
18+
},
19+
"7": {
20+
"value": "7px",
21+
"type": "dimension"
22+
},
23+
"8": {
24+
"value": "8px",
25+
"type": "dimension"
26+
},
27+
"10": {
28+
"value": "10px",
29+
"type": "dimension"
30+
},
31+
"12": {
32+
"value": "12px",
33+
"type": "dimension"
34+
},
35+
"14": {
36+
"value": "14px",
37+
"type": "dimension"
38+
},
39+
"16": {
40+
"value": "16px",
41+
"type": "dimension"
42+
},
43+
"20": {
44+
"value": "20px",
45+
"type": "dimension"
46+
},
47+
"32": {
48+
"value": "32px",
49+
"type": "dimension"
50+
},
51+
"rounded-half": {
52+
"value": "9999px",
53+
"type": "dimension"
54+
},
55+
"smooth-corner": {
56+
"value": "42%",
57+
"type": "dimension"
58+
}
59+
}
60+
}

0 commit comments

Comments
 (0)