Skip to content

Commit f4f78ff

Browse files
authored
Add fill-grey-light color token and update component background colors (#2782)
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [ ] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> closes webtech-4605 <!-- Fixes #0000 --> ## Summary 누락되었던 `fill-grey-light` 토큰을 추가하고 컴포넌트들의 배경색을 수정합니다. <!-- Please brief explanation of the changes made --> ## Details <!-- Please elaborate description of the changes --> - `fill-grey-light` 토큰 추가 - TextField, Textarea focus된 상태일 때 배경색을 `fill-grey-light`로 변경 - control(radio, checkbox)들의 기본 배경색을 `fill-grey-light`로 변경 - AlphaIconButton의 tertiary dark-grey, light-grey의 호버 시 색상이 적용되지 않는 문제 확인하여 실제 존재하는 토큰으로 변경 (`color-fill-neutral-transparent-hovered`) - AlphaFloatingButton, AlphaIconFloatingButton의 secondary 배경색을 `fill-grey`로 변경 ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> No ## References <!-- Please list any other resources or points the reviewer should be aware of --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## 릴리스 노트 * **새로운 기능** * 디자인 시스템에 새로운 색상 토큰을 추가했습니다. * **스타일** * Checkbox, RadioGroup, TextField(포커스/유효성 검사 상태), TextArea(포커스 상태)의 배경색을 업데이트했습니다. * FloatingButton과 FloatingIconButton의 보조 변형 스타일을 개선했습니다. * IconButton 호버 상태에 대한 경미한 스타일 개선을 적용했습니다. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent bdc6029 commit f4f78ff

File tree

10 files changed

+24
-16
lines changed

10 files changed

+24
-16
lines changed

.changeset/proud-lions-wonder.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@channel.io/bezier-tokens': patch
3+
'@channel.io/bezier-react': patch
4+
---
5+
6+
Add fill-grey-light color token and update component background colors: TextField-primary and TextArea focus states, RadioGroup and Checkbox defaults, and some buttons.

packages/bezier-react/src/components/AlphaFloatingButton/FloatingButton.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
108108
}
109109

110110
&:where(.variant-secondary) {
111-
background-color: var(--color-surface-highest);
111+
background-color: var(--color-fill-grey);
112112
}
113113

114114
/* color */

packages/bezier-react/src/components/AlphaFloatingIconButton/FloatingIconButton.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
8989
}
9090

9191
&:where(.variant-secondary) {
92-
background-color: var(--color-surface-highest);
92+
background-color: var(--color-fill-grey);
9393
}
9494

9595
/* color */

packages/bezier-react/src/components/AlphaIconButton/IconButton.module.scss

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,7 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
185185
@each $color in $chromatic-colors {
186186
&:where(.color-#{'' + $color}) {
187187
/* stylelint-disable-next-line bezier/validate-token */
188-
background-color: var(
189-
--color-fill-accent-#{$color}-heavier-hovered
190-
);
188+
background-color: var(--color-fill-accent-#{$color}-heavier-hovered);
191189
}
192190
}
193191

@@ -224,15 +222,11 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
224222
}
225223

226224
&:where(.color-dark-grey, .color-light-grey) {
227-
background-color: var(
228-
--color-fill-neutral-lighter-transparent-hovered
229-
);
225+
background-color: var(--color-fill-neutral-transparent-hovered);
230226
}
231227

232228
&:where(.color-white-absolute) {
233-
background-color: var(
234-
--color-fill-absolute-white-transparent-hovered
235-
);
229+
background-color: var(--color-fill-absolute-white-transparent-hovered);
236230
}
237231
}
238232

packages/bezier-react/src/components/Checkbox/Checkbox.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
margin: 1px;
2020

21-
background-color: var(--color-surface);
21+
background-color: var(--color-fill-grey-light);
2222
border-radius: 7px;
2323
box-shadow: inset 0 0 0 2px var(--color-border-neutral-heavy);
2424

packages/bezier-react/src/components/RadioGroup/RadioGroup.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ $inner-indicator-size: 8px;
4545
box-sizing: border-box;
4646
margin: $outer-indicator-margin;
4747

48-
background-color: var(--color-surface);
48+
background-color: var(--color-fill-grey-light);
4949
border-radius: 50%;
5050
outline: none;
5151
box-shadow: inset 0 0 0 2px var(--color-border-neutral-heavy);

packages/bezier-react/src/components/TextArea/TextArea.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@
3939
}
4040

4141
&:focus {
42-
background-color: var(--color-surface);
42+
background-color: var(--color-fill-grey-light);
4343
box-shadow: var(--state-input-active);
4444
}
4545

4646
&[aria-invalid='true'] {
47-
background-color: var(--color-surface);
47+
background-color: var(--color-fill-grey-light);
4848
box-shadow: var(--state-input-error);
4949
}
5050

packages/bezier-react/src/components/TextField/TextField.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
:has(.TextFieldInput[aria-invalid='true']),
8181
:has(.TextFieldInput:not(:disabled, :read-only):focus)
8282
) {
83-
background-color: var(--color-surface);
83+
background-color: var(--color-fill-grey-light);
8484
}
8585

8686
&:where(.variant-primary:has(.TextFieldInput:read-only)) {

packages/bezier-tokens/src/beta/semantic/dark-theme/color.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,10 @@
317317
}
318318
},
319319
"grey": {
320+
"light": {
321+
"value": "{color.grey.900}",
322+
"type": "color"
323+
},
320324
"normal": {
321325
"value": "{color.grey.850}",
322326
"type": "color"

packages/bezier-tokens/src/beta/semantic/light-theme/color.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,10 @@
317317
}
318318
},
319319
"grey": {
320+
"light": {
321+
"value": "{color.grey.25}",
322+
"type": "color"
323+
},
320324
"normal": {
321325
"value": "{color.grey.50}",
322326
"type": "color"

0 commit comments

Comments
 (0)