Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Commit 6665b89

Browse files
committed
Belt and braces fix for #23 and some flow fixes for newer flow versions
1 parent e741556 commit 6665b89

File tree

2 files changed

+36
-27
lines changed

2 files changed

+36
-27
lines changed

src/App.js

Lines changed: 35 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default class App {
1616
this._capacityCalculator = new CapacityCalculator();
1717
}
1818

19-
async runAsync(event: any, context: any): Promise {
19+
async runAsync(event: any, context: any): Promise<void> {
2020
invariant(event != null, 'The argument \'event\' was null');
2121
invariant(context != null, 'The argument \'context\' was null');
2222

@@ -48,11 +48,8 @@ export default class App {
4848
this._logMetrics(tableDetails);
4949

5050
// Return an empty response
51-
let response = null;
5251
if (context) {
53-
context.succeed(response);
54-
} else {
55-
return response;
52+
context.succeed(null);
5653
}
5754
}
5855

@@ -103,7 +100,7 @@ export default class App {
103100
return result;
104101
}
105102

106-
async _updateTablesAsync(tableUpdateRequests: UpdateTableRequest[]): Promise {
103+
async _updateTablesAsync(tableUpdateRequests: UpdateTableRequest[]): Promise<void> {
107104
invariant(tableUpdateRequests instanceof Array,
108105
'The argument \'tableUpdateRequests\' was not an array');
109106

@@ -117,7 +114,7 @@ export default class App {
117114
}
118115

119116
async _updateTableAsync(tableUpdateRequest: UpdateTableRequest,
120-
isRateLimitedUpdatingRequired: boolean): Promise {
117+
isRateLimitedUpdatingRequired: boolean): Promise<void> {
121118
invariant(tableUpdateRequest != null, 'The argument \'tableUpdateRequest\' was null');
122119
invariant(typeof isRateLimitedUpdatingRequired === 'boolean',
123120
'The argument \'isRateLimitedUpdatingRequired\' was not a boolean');
@@ -160,26 +157,38 @@ export default class App {
160157
};
161158
}, {ReadCapacityUnits: 0, WriteCapacityUnits: 0});
162159

160+
let indexHandler = stJSON['Index.handler'] != null ? {
161+
mean: stJSON['Index.handler'].histogram.mean
162+
} : undefined;
163+
164+
let dynamoDBListTablesAsync = stJSON['DynamoDB.listTablesAsync'] != null ? {
165+
mean: stJSON['DynamoDB.listTablesAsync'].histogram.mean,
166+
} : undefined;
167+
168+
let dynamoDBDescribeTableAsync = stJSON['DynamoDB.describeTableAsync'] != null ? {
169+
mean: stJSON['DynamoDB.describeTableAsync'].histogram.mean,
170+
} : undefined;
171+
172+
let dynamoDBDescribeTableConsumedCapacityAsync =
173+
stJSON['DynamoDB.describeTableConsumedCapacityAsync'] != null ?
174+
{ mean: stJSON['DynamoDB.describeTableConsumedCapacityAsync'].histogram.mean } :
175+
undefined;
176+
177+
let cloudWatchGetMetricStatisticsAsync =
178+
stJSON['CloudWatch.getMetricStatisticsAsync'] != null ?
179+
{ mean: stJSON['CloudWatch.getMetricStatisticsAsync'].histogram.mean } :
180+
undefined;
181+
182+
let tableUpdates = updateRequests != null ? { count: updateRequests.length } :
183+
undefined;
184+
163185
log(JSON.stringify({
164-
'Index.handler': {
165-
mean: stJSON['Index.handler'].histogram.mean
166-
},
167-
'DynamoDB.listTablesAsync': {
168-
mean: stJSON['DynamoDB.listTablesAsync'].histogram.mean,
169-
},
170-
'DynamoDB.describeTableAsync': {
171-
mean: stJSON['DynamoDB.describeTableAsync'].histogram.mean,
172-
},
173-
'DynamoDB.describeTableConsumedCapacityAsync': {
174-
mean: stJSON['DynamoDB.describeTableConsumedCapacityAsync']
175-
.histogram.mean,
176-
},
177-
'CloudWatch.getMetricStatisticsAsync': {
178-
mean: stJSON['CloudWatch.getMetricStatisticsAsync'].histogram.mean,
179-
},
180-
TableUpdates: {
181-
count: updateRequests.length,
182-
},
186+
'Index.handler': indexHandler,
187+
'DynamoDB.listTablesAsync': dynamoDBListTablesAsync,
188+
'DynamoDB.describeTableAsync': dynamoDBDescribeTableAsync,
189+
'DynamoDB.describeTableConsumedCapacityAsync': dynamoDBDescribeTableConsumedCapacityAsync,
190+
'CloudWatch.getMetricStatisticsAsync': cloudWatchGetMetricStatisticsAsync,
191+
TableUpdates: tableUpdates,
183192
TotalProvisionedThroughput: totalProvisionedThroughput,
184193
TotalMonthlyEstimatedCost: totalMonthlyEstimatedCost,
185194
}, null, json.padding));

src/aws/DynamoDB.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export default class DynamoDB {
8282
}
8383
}
8484

85-
async delayUntilTableIsActiveAsync(tableName: string): Promise {
85+
async delayUntilTableIsActiveAsync(tableName: string): Promise<void> {
8686
let isActive = false;
8787
let attempt = 0;
8888
do {

0 commit comments

Comments
 (0)