Update configuration priority.

Author: chantera

README.md

@@ -18,4 +18,4 @@ These are the valid configuration keys:
 - `pylsp.plugins.isort.enabled`: boolean to enable/disable the plugin. `true` by default.
 - `pylsp.plugins.isort.*`: any other key-value pair under `pylsp.plugins.isort` is passed to `isort.settings.Config`. See the [reference](https://pycqa.github.io/isort/reference/isort/settings.html#config) for details.
 
-Note that any configurations passed to isort via `pylsp` will override the settings in a config file, such as `pyproject.toml`.
+Note that any configurations passed to isort via `pylsp` are ignored when isort detects a config file, such as `pyproject.toml`.

pylsp_isort/plugin.py

@@ -103,11 +103,19 @@ def isort_config(
         else:
             config_kwargs["settings_path"] = os.path.abspath(settings["settings_path"])
     elif target_path:
-        config_kwargs["settings_path"] = os.path.abspath(target_path)
-        if not os.path.isdir(config_kwargs["settings_path"]):
-            config_kwargs["settings_path"] = os.path.dirname(
-                config_kwargs["settings_path"]
+        settings_path = os.path.abspath(target_path)
+        if not os.path.isdir(settings_path):
+            settings_path = os.path.dirname(settings_path)
+
+        _, found_settings = isort.settings._find_config(settings_path)
+        if found_settings:
+            logger.info(
+                "Found a config file: `%s`, skipping given settings.",
+                found_settings["source"],
             )
+            config_kwargs = {}
+
+        config_kwargs["settings_path"] = settings_path
 
     logger.debug("config_kwargs=%r", config_kwargs)
     if unsupported_kwargs:

tests/test_plugin.py

@@ -66,6 +66,12 @@ def test_run_isort(text, settings, expected):
             isort.Config(profile="black"),
             False,
         ),
+        (
+            {"profile": "django"},
+            __file__,
+            isort.Config(profile="black"),
+            False,
+        ),
     ],
 )
 def test_isort_config(settings, target_path, expected, check_sources):