fix(test): test coverage

chantouchsek · chantouchsek · commit ba7d69e24898 · 2023-01-18T11:36:54.000+07:00
diff --git a/package.json b/package.json
@@ -6,6 +6,7 @@
   "types": "dist/index.d.ts",
   "scripts": {
     "test": "vitest --run",
+    "test:cov": "vitest run --coverage",
     "test:watch": "yarnr test",
     "build": "yarn clean && tsc",
     "watch": "tsc -w",
@@ -54,6 +55,7 @@
     "@types/qs": "^6.9.7",
     "@typescript-eslint/eslint-plugin": "^5.9.0",
     "@typescript-eslint/parser": "^5.9.0",
+    "@vitest/coverage-c8": "^0.27.2",
     "@vue/test-utils": "^1.2.2",
     "axios-mock-adapter": "^1.20.0",
     "eslint": "^8.13.0",
@@ -62,6 +64,7 @@
     "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-promise": "^6.0.0",
     "husky": "^8.0.1",
+    "jsdom": "^21.0.0",
     "lint-staged": ">=10",
     "nodemon": "^2.0.12",
     "nuxt-edge": "^2.16.0-27217455.034b9901",
diff --git a/src/__tests__/__snapshots__/package.spec.ts.snap b/src/__tests__/__snapshots__/package.spec.ts.snap
@@ -25,29 +25,3 @@ exports[`Vue Api Queries > Get plugin installed 1`] = `
   />
 </body>
 `;
-
-exports[`Vue Api Queries Get errors from vue component 1`] = `
-Object {
-  "$_vueTestUtils_original": [Circular],
-  "_Ctor": Object {},
-  "data": [Function],
-  "name": undefined,
-  "render": [Function],
-  "staticRenderFns": Array [],
-  "template": "
-      <div>
-        <input type=\\"checkbox\\" name=\\"t1\\" class=\\"foo\\" v-model=\\"t1\\" />
-        <input type=\\"radio\\" name=\\"t2\\" class=\\"foo\\" value=\\"foo\\" v-model=\\"t2\\"/>
-        <input type=\\"radio\\" name=\\"t2\\" class=\\"bar\\" value=\\"bar\\" v-model=\\"t2\\"/>
-        <span id=\\"age\\">{{ $errors.first('age') }}</span>
-      </div>",
-}
-`;
-
-exports[`Vue Api Queries Get plugin installed 1`] = `
-<body>
-  <div
-    data-app="true"
-  />
-</body>
-`;
diff --git a/src/core/Validator.ts b/src/core/Validator.ts
@@ -41,14 +41,11 @@ class Validator {
 
   first(field: string | string[]): string | object {
     if (Array.isArray(field)) {
-      for (let i = 0; i < field.length; i++) {
-        if (!has(this.errors, field[i])) {
-          continue
-        }
-        return this.first(field[i])
+      for (const f of field) {
+        if (has(this.errors, f)) return this.first(f)
       }
     }
-    const value = this.get(field as string)
+    const value = this.get(field)
     if (Array.isArray(value)) return value[0]
     return value
   }
@@ -89,7 +86,7 @@ class Validator {
     return Object.keys(errors).length > 0
   }
 
-  get(field: string): string | string[] {
+  get(field: string | string[]): string | string[] {
     return get(this.errors, field, [])
   }
 
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -41,14 +41,11 @@ class Validator {`
`41`	`41`
`42`	`42`	`first(field: string \| string[]): string \| object {`
`43`	`43`	`if (Array.isArray(field)) {`
`44`		`- for (let i = 0; i < field.length; i++) {`
`45`		`- if (!has(this.errors, field[i])) {`
`46`		`- continue`
`47`		`- }`
`48`		`- return this.first(field[i])`
	`44`	`+ for (const f of field) {`
	`45`	`+ if (has(this.errors, f)) return this.first(f)`
`49`	`46`	`}`
`50`	`47`	`}`
`51`		`- const value = this.get(field as string)`
	`48`	`+ const value = this.get(field)`
`52`	`49`	`if (Array.isArray(value)) return value[0]`
`53`	`50`	`return value`
`54`	`51`	`}`
`@@ -89,7 +86,7 @@ class Validator {`
`89`	`86`	`return Object.keys(errors).length > 0`
`90`	`87`	`}`
`91`	`88`
`92`		`- get(field: string): string \| string[] {`
	`89`	`+ get(field: string \| string[]): string \| string[] {`
`93`	`90`	`return get(this.errors, field, [])`
`94`	`91`	`}`
`95`	`92`