Merge pull request #318 from chantouchsek/feat/remove-transformer-files

Feat/remove transformer files

Author: chantouchsek

jest.config.ts

@@ -7,8 +7,8 @@ const config: InitialOptionsTsJest = {
     global: {
       lines: 100,
       functions: 100,
-      branches: 93.44,
-      statements: 99.39,
+      branches: 92.72,
+      statements: 99.33,
     },
   },
   testEnvironment: 'node',

package.json

@@ -59,7 +59,7 @@
     "@vue/test-utils": "^1.2.2",
     "axios": "^0.26.1",
     "axios-mock-adapter": "^1.20.0",
-    "eslint": "^8.6.0",
+    "eslint": "^8.13.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-import": "^2.24.2",
     "eslint-plugin-prettier": "^4.0.0",
@@ -81,9 +81,7 @@
     "nuxt"
   ],
   "dependencies": {
-    "camelcase-keys": "^7.0.1",
-    "qs": "^6.10.2",
-    "snakecase-keys": "^5.1.2"
+    "qs": "^6.10.2"
   },
   "lint-staged": {
     "*.{js,ts}": "eslint --cache",

src/__tests__/base-proxy.test.ts

@@ -4,8 +4,6 @@ import MockAdapter from 'axios-mock-adapter'
 import PostProxy from '../util/PostPorxy'
 import type { ValidatorType } from '../core/Validator'
 import Validator from '../core/Validator'
-import BaseTransformer from '../core/BaseTransformer'
-import PaginationTransformer from '../core/PaginationTransformer'
 import { merge } from '../util'
 
 let proxy: PostProxy
@@ -39,10 +37,10 @@ describe('BaseProxy', () => {
       pagination: { count: 1, page: 1, perPage: 20 },
     }
     mockAdapter.onGet('/posts').reply(200, items)
-    const { data, pagination = {} } = await proxy.removeParameters().all()
+    const { data, pagination } = await proxy.removeParameters().all()
     const all = {
-      items: BaseTransformer.fetchCollection(data),
-      pagination: PaginationTransformer.fetch(pagination),
+      pagination,
+      items: data,
     }
     expect(all).toHaveProperty('pagination')
     expect(data).toEqual(all.items)
@@ -53,35 +51,19 @@ describe('BaseProxy', () => {
     const items = {
       data: [{ first_name: 'Chantouch', last_name: 'Sek' }],
       meta: {
-        pagination: { count: 1, current_page: 1, perPage: 20 },
+        pagination: { count: 1, page: 1, perPage: 20 },
         include: [],
       },
     }
     mockAdapter.onGet('/posts').reply(200, items)
-    const { data, meta = {} } = await proxy.removeParameters().all()
-    const all = {
-      items: BaseTransformer.fetchCollection(data),
-      pagination: PaginationTransformer.fetch(meta),
+    const { data, meta } = await proxy.removeParameters().all()
+    const item = {
+      items: data,
+      pagination: meta.pagination,
     }
     expect(meta).toHaveProperty('pagination')
     expect(data.length).toEqual(1)
-    expect(all.pagination.page).toEqual(1)
-  })
-
-  it('should assign default object meta if it is null or undefined', async () => {
-    const items = {
-      data: [{ first_name: 'Chantouch', last_name: 'Sek' }],
-      meta: undefined,
-    }
-    mockAdapter.onGet('/posts').reply(200, items)
-    const { data, meta } = await proxy.removeParameters([]).all()
-    const all = {
-      items: BaseTransformer.fetchCollection(data),
-      pagination: PaginationTransformer.fetch(meta),
-    }
-    expect(meta).toBeUndefined()
-    expect(data.length).toEqual(1)
-    expect(all.pagination.currentPage).toEqual(1)
+    expect(item.pagination.page).toEqual(1)
   })
 
   it('will fetch all records', async () => {

src/__tests__/base-transformer.test.ts

@@ -2,8 +2,6 @@ import Axios from 'axios'
 import BaseProxy from '../core/BaseProxy'
 import PostProxy from '../util/PostPorxy'
 import MockAdapter from 'axios-mock-adapter'
-import BaseTransformer from '../core/BaseTransformer'
-import PaginationTransformer from '../core/PaginationTransformer'
 
 let proxy: PostProxy
 let mockAdapter: MockAdapter
@@ -21,25 +19,26 @@ describe('PostProxy', () => {
     const items = {
       data: [{ name: 'Chantouch', post_id: 1 }],
       meta: {
-        pagination: { count: 1, current_page: 1, perPage: 20 },
+        pagination: { count: 1, page: 1, perPage: 20 },
         include: [],
       },
     }
     mockAdapter.onGet('/posts/1/tags').reply(200, items)
-    const { data, meta = {} } = await proxy.tags(1)
-    const all = {
-      items: BaseTransformer.fetchCollection(data),
-      pagination: PaginationTransformer.fetch(meta),
+    const { data, meta } = await proxy.tags(1)
+    const item = {
+      items: data,
+      pagination: meta.pagination,
     }
+    console.warn('meta', item.pagination)
     expect(meta).toHaveProperty('pagination')
     expect(data.length).toEqual(1)
-    expect(all.pagination.page).toEqual(1)
+    expect(item.pagination.page).toEqual(1)
   })
   it('it should throw exception if method is not inlist', async () => {
     const items = {
       data: [{ name: 'Chantouch', post_id: 1 }],
       meta: {
-        pagination: { count: 1, current_page: 1, perPage: 20 },
+        pagination: { count: 1, page: 1, perPage: 20 },
         include: [],
       },
     }

src/__tests__/post-proxy.spec.ts

@@ -1,8 +1,6 @@
 import type { ValidatorType } from './core/Validator'
 import BaseProxy from './core/BaseProxy'
 import Validator from './core/Validator'
-import BaseTransformer from './core/BaseTransformer'
-import PaginationTransformer from './core/PaginationTransformer'
 import { merge } from './util'
 import _Vue from 'vue'
 
@@ -51,12 +49,6 @@ class AxiosHttp {
     })
   }
 }
-export {
-  Validator,
-  BaseProxy,
-  BaseTransformer,
-  PaginationTransformer,
-  BaseProxy as BaseService,
-}
+export { Validator, BaseProxy, BaseProxy as BaseService }
 export * from './util'
 export default new AxiosHttp()