Skip to content

Fix/dependency resolution robustness #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgoggins merged 2 commits into from
Jan 26, 2026
Merged

Fix/dependency resolution robustness #3608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2243245
[tasks] fix: undefined variable 's' in start_tasks.py
atheendre130505 Jan 18, 2026
60868f8
[tasks] fix: skip dependencies with invalid/missing version info
atheendre130505 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 46 additions & 42 deletions augur/tasks/git/dependency_libyear_tasks/libyear_util/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,69 +111,73 @@ def get_deps_libyear_data(path, logger):
#NOTE: Add new if for new package parser
if dependency['package'] == 'PYPI':
data = get_pypi_data(dependency['name'])
if not data:
logger.warning(f"Skipping dependency {dependency['name']} - could not find package on PYPI.")
continue

try:
current_version = sort_dependency_requirement(dependency,data)
except (KeyError, TypeError) as e:
logger.error(f"Could not get current version of dependency for path {path}.\n Dependency: {dependency}")
current_version = None
logger.warning(f"Skipping dependency {dependency['name']} - could not resolve current version requirement: {dependency['requirement']}")
continue

if not current_version:
logger.warning(f"Skipping dependency {dependency['name']} - current version is null or unspecified.")
continue

try:
latest_version = get_latest_version(data)

except KeyError:
logger.error(f"Could not get current version of dependency for path {path}.\n Dependency: {dependency}")
latest_version = None
except (KeyError, TypeError):
logger.warning(f"Skipping dependency {dependency['name']} - could not get latest version from PYPI.")
continue

if not latest_version:
logger.warning(f"Skipping dependency {dependency['name']} - latest version is null.")
continue

try:
if latest_version:
latest_release_date = get_release_date(data, latest_version,logger)
else:
latest_release_date = None
latest_release_date = get_release_date(data, latest_version, logger)
current_release_date = get_release_date(data, current_version, logger)
except KeyError:
logger.error(f"Could not get current date of dependency for path {path} with version {latest_version}.\n Dependency: {dependency}")
latest_release_date = None

if current_version:
current_release_date = get_release_date(data, current_version,logger)
logger.warning(f"Skipping dependency {dependency['name']} - could not find release dates for version {current_version} or {latest_version}.")
continue

if not current_release_date or not latest_release_date:
logger.warning(f"Skipping dependency {dependency['name']} - missing release date information.")
continue

elif dependency['package'] == 'NPM':
data = get_NPM_data(dependency['name'])
if not data:
logger.warning(f"Skipping dependency {dependency['name']} - could not find package on NPM.")
continue

current_version = get_npm_current_version(data, dependency['requirement'])
if not current_version:
logger.warning(f"Skipping dependency {dependency['name']} - could not resolve current version from requirement: {dependency['requirement']}")
continue

try:
latest_version = get_npm_latest_version(data)
except KeyError:
logger.error(f"Could not get latest version of dependency for path {path}.\n Dependency: {dependency}")
logger.warning(f"Skipping dependency {dependency['name']} - could not get latest version from NPM.")
latest_version = None

if not latest_version:
continue

try:
if latest_version:
latest_release_date = get_npm_release_date(data, latest_version)
else:
latest_release_date = None
latest_release_date = get_npm_release_date(data, latest_version)
current_release_date = get_npm_release_date(data, current_version)
except KeyError:
logger.error(f"Could not get latest version of dependency for path {path}.\n Dependency: {dependency}")
latest_release_date = None

if current_version:
try:
current_release_date = get_npm_release_date(data, current_version)
except KeyError:
logger.error(f"Could not get latest version of dependency for path {path}.\n Dependency: {dependency}")
current_release_date = dateutil.parser.parse('1970-01-01 00:00:00')
logger.warning(f"Skipping dependency {dependency['name']} - missing release date info on NPM for {current_version}/{latest_version}")
continue
else:
# Unsupported package manager
continue


libyear = get_libyear(current_version, current_release_date, latest_version, latest_release_date)

if not latest_release_date:
latest_release_date = dateutil.parser.parse('1970-01-01 00:00:00')
libyear = -1

if not latest_version:
latest_version = 'unspecified'

if not current_version:
current_version = latest_version
current_release_date = latest_release_date

if not dependency['requirement']:
dependency['requirement'] = 'unspecified'

Expand All @@ -183,4 +187,4 @@ def get_deps_libyear_data(path, logger):
dependency['latest_release_date'] = latest_release_date
dependency['libyear'] = libyear

return [d for d in dependencies if d]
return [d for d in dependencies if 'libyear' in d]
1 change: 1 addition & 0 deletions augur/tasks/start_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#from celery.result import AsyncResult
from celery import group, chain
from sqlalchemy import and_,update
import sqlalchemy as s


from augur.tasks.github import *
Expand Down Expand Up @@ -304,7 +305,7 @@
status = repo.collection_status[0]
raw_count = status.issue_pr_sum

issue_pr_task_update_weight_util([int(raw_count)],repo_git=repo_git,session=session)

Check warning on line 308 in augur/tasks/start_tasks.py

View workflow job for this annotation

GitHub Actions / runner / pylint 

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'issue_and_pr_nums' in function call (no-value-for-parameter)

Raw Output:
augur/tasks/start_tasks.py:308:12: E1120: No value for argument 'issue_and_pr_nums' in function call (no-value-for-parameter)

facade_not_pending = CollectionStatus.facade_status != CollectionState.PENDING.value
facade_not_failed = CollectionStatus.facade_status != CollectionState.FAILED_CLONE.value
Expand Down
Loading