From 6546d5227bc1447d6fa4d27577602549f9ca925f Mon Sep 17 00:00:00 2001 From: Jakeer R <39124730+rkjakeer@users.noreply.github.com> Date: Wed, 11 Sep 2024 07:50:20 +0530 Subject: [PATCH 1/2] Update actions.py fix typo Signed-off-by: Jakeer R <39124730+rkjakeer@users.noreply.github.com> --- chaosgcp/apphub/actions.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/chaosgcp/apphub/actions.py b/chaosgcp/apphub/actions.py index e4f5c8b..8649de5 100644 --- a/chaosgcp/apphub/actions.py +++ b/chaosgcp/apphub/actions.py @@ -221,11 +221,11 @@ def inject_fault_if_url_map_exists_app_hub( region (str): The region of the AppHub application. target_name (str): the the name of a path matcher in the URL map. target_path (str): default "/*", - impacted_percentage: float default 50.0, - http_status (int) default 400, - regional: (bool) default True, - configuration: (Configuration) default None, - secrets: (Secrets) default None, + impacted_percentage (float): default 50.0, + http_status (int): default 400, + regional (bool): default True, + configuration (Configuration): default None, + secrets (Secrets): default None, """ if not url_map_exists( @@ -282,8 +282,8 @@ def remove_fault_if_url_map_exists_app_hub( target_name (str): the the name of a path matcher in the URL map. target_path (str): default "/*", regional: (bool) default True, - configuration: (Configuration) default None, - secrets: (Secrets) default None, + configuration (Configuration): default None, + secrets (Secrets): default None, """ if not url_map_exists( From 5ef45f64076af9db2b9e94c74afeefcf2c30c044 Mon Sep 17 00:00:00 2001 From: Jakeer R <39124730+rkjakeer@users.noreply.github.com> Date: Wed, 11 Sep 2024 08:01:21 +0530 Subject: [PATCH 2/2] remove invalid comment in google style docstring Raises area Signed-off-by: Jakeer R <39124730+rkjakeer@users.noreply.github.com> --- chaosgcp/iam/controls/policy.py | 1 - 1 file changed, 1 deletion(-) diff --git a/chaosgcp/iam/controls/policy.py b/chaosgcp/iam/controls/policy.py index 058afcb..12d51af 100644 --- a/chaosgcp/iam/controls/policy.py +++ b/chaosgcp/iam/controls/policy.py @@ -191,7 +191,6 @@ def manage_time_bound_temporary_iam_roles( Raises: TypeError: If any of the arguments are not of the expected type. ValueError: If `manage_type` is not "add" or "remove". - # (Add other potential exceptions based on your IAM implementation) Example: # Grant roles with a 15-minute expiration: