Fix endless loop on repeat control

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>

Author: Lawouach

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 [Unreleased]: https://github.com/chaostoolkit/chaostoolkit-addons/compare/0.8.6...HEAD
 
+### Fixed
+
+* Make sure the `repeat` control doesn't run when it count is less than 2
+
 ### Changed
 
 - Switched to ruff to lint the code

chaosaddons/controls/repeat.py

@@ -43,10 +43,21 @@ def after_activity_control(context: Activity, experiment: Experiment,
     You may set `break_if_previous_iteration_failed` to stop iterating if
     an activity failed to run. Note it's not about the return value of
     the activity but if it actually executed as planned.
+
+    Note, if `repeat_count` is less than 2, then this is a noop.
     """
     activity = context
     activity_name = activity["name"]
+    activity_type = activity["type"]
+
     repeat_count = repeat_count - 1
+    if repeat_count <= 0:
+        logger.debug(
+            f"Do not repeat {activity_type} '{activity_name}' when "
+            "`repeat_count` is less than 2"
+        )
+        return None
+
     last_status = state.get("status")
 
     if break_if_previous_iteration_failed and last_status != "succeeded":

tests/test_repeat.py

@@ -52,3 +52,58 @@ def test_repeat_n_times_in_hypothesis():
     )
 
     assert len(x.get("steady-state-hypothesis").get("probes")) == 4
+
+
+def test_repeat_once_in_hypothesis():
+    a = {
+        "name": "probe-B",
+        "type": "probe",
+        "provider": {
+            "type": "python",
+            "module": "builtins",
+            "func": "sum",
+            "arguments": {
+                "iterable": [6, 7]
+            }
+        }
+    }
+    x = {
+        "title": "hello",
+        "description": "n/a",
+        "method": [
+                {
+                    "name": "probe-A",
+                    "type": "probe",
+                    "provider": {
+                        "type": "python",
+                        "module": "builtins",
+                        "func": "sum",
+                        "arguments": {
+                            "iterable": [2, 3]
+                        }
+                    }
+                },
+                a,
+                {
+                    "name": "probe-C",
+                    "type": "probe",
+                    "provider": {
+                        "type": "python",
+                        "module": "builtins",
+                        "func": "sum",
+                        "arguments": {
+                            "iterable": [2, 3]
+                        }
+                    }
+                },
+            ]
+    }
+
+    assert len(x.get("method")) == 3
+    
+    after_activity_control(
+        context=a, experiment=x, state={},
+        repeat_count=1
+    )
+
+    assert len(x.get("method")) == 4