don't leave before visiting all nodes

Lawouach · Lawouach · commit 35d2c39d1250 · 2023-11-13T15:51:06.000+01:00
Signed-off-by: Sylvain Hellegouarch &lt;sh@defuze.org&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,15 @@
 
 ## [Unreleased][]
 
-[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.0...HEAD
+[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.1...HEAD
+
+## [0.34.1][] - 2023-11-13
+
+[0.34.1]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.0...0.34.1
+
+### Fixed
+
+* Don't escape node draining too soon
 
 ## [0.34.0][] - 2023-11-13
 
diff --git a/chaosk8s/node/actions.py b/chaosk8s/node/actions.py
@@ -348,8 +348,8 @@ def drain_nodes(
                 )
 
         if not eviction_candidates:
-            logger.debug("No pods to evict. Let's return.")
-            return True
+            logger.debug("No pods to evict. Let's move on to the next node.")
+            continue
 
         logger.debug(f"Found {len(eviction_candidates)} pods to evict")
         for pod in eviction_candidates:

Original file line number	Diff line number	Diff line change
`@@ -348,8 +348,8 @@ def drain_nodes(`
`348`	`348`	`)`
`349`	`349`
`350`	`350`	`if not eviction_candidates:`
`351`		`- logger.debug("No pods to evict. Let's return.")`
`352`		`- return True`
	`351`	`+ logger.debug("No pods to evict. Let's move on to the next node.")`
	`352`	`+ continue`
`353`	`353`
`354`	`354`	`logger.debug(f"Found {len(eviction_candidates)} pods to evict")`
`355`	`355`	`for pod in eviction_candidates:`