TestReadInt fails on s390x (big-endian)

[QuLogic]

Tests used to pass on 1.0.11, but fail in 1.0.12:

github.com/charlievieth/fastwalk/internal/dirent
--- FAIL: TestReadInt (0.00s)
    --- FAIL: TestReadInt/1 (0.00s)
        endian_test.go:24: readInt("\x7f\x00\x00\x00\x00\x00\x00\x00", 0, 1) = 127, true want: 9151314442816847872, true
    --- FAIL: TestReadInt/2 (0.00s)
        endian_test.go:24: readInt("\x7f\xff\x00\x00\x00\x00\x00\x00", 0, 2) = 32767, true want: 9223090561878065152, true
    --- FAIL: TestReadInt/4 (0.00s)
        endian_test.go:24: readInt("\x7f\xff\xff\xff\x00\x00\x00\x00", 0, 4) = 2147483647, true want: 9223372032559808512, true
FAIL

[QuLogic]

At least this part of the test seems little-endian specific to me: v1.0.11...v1.0.12#diff-288505f1dc15be712755ee81d2134c954700a741df3c97945e4bad617b9d4942R20

[QuLogic]

Actually, the test doesn't make too much sense to me, even in little-endian. Almost all the bits are on, which doesn't seem like a great check, since you could easily byte-swap a 16-bit value and still get the same result.

[charlievieth]

@QuLogic apologies for the delay I somehow missed this issue and thank you for bringing this test failure to my attention. I think we can simplify things by using binary. NativeEndian which will allow for us to remove the platform specific code and the offending test.

[charlievieth]

Created #65 to remove a bad test from that was added by #65. Will cut a new release once #65 is merged.

[pleia2]

@charlievieth In case you are interested in doing any tests on s390x, we do have temporary VMs available through the IBM LinuxONE Community Cloud: https://community.ibm.com/zsystems/l1cc and longer-lived ones through our Open Source program (which you'd be eligible for!): https://community.ibm.com/zsystems/form/l1cc-oss-vm-request/

[charlievieth]

@charlievieth In case you are interested in doing any tests on s390x, we do have temporary VMs available through the IBM LinuxONE Community Cloud: https://community.ibm.com/zsystems/l1cc and longer-lived ones through our Open Source program (which you'd be eligible for!): https://community.ibm.com/zsystems/form/l1cc-oss-vm-request/

Amazing - thank you!