Rewrote Tests to be more specific

- rewrote tests
- Move exampleSuffixer to suffixer.go changed other files accordingly
- removed redundant Border checks within Lines()
- changed DefaultPrefixer to mark wraped line if selected

Author: [email protected]

list/example/main.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"github.com/charmbracelet/bubbles/list"
 	tea "github.com/charmbracelet/bubbletea"
-	"github.com/muesli/reflow/ansi"
 	"os"
 	"strconv"
 	"strings"
@@ -46,16 +45,16 @@ func main() {
 	stringerList := list.MakeStringerList(itemList)
 
 	endResult := make(chan string, 1)
-	list := list.NewModel()
-	list.AddItems(stringerList)
-	list.SuffixGen = &exampleSuffixer{currentMarker: "<"}
+	l := list.NewModel()
+	l.AddItems(stringerList)
+	l.SuffixGen = list.NewSuffixer()
 
 	// Since in this example we only use UNIQUE string items we can use a String Comparison for the equals methode
 	// but be aware that different items in your case can have the same string -> false-positiv
 	// Better: Assert back to your struct and test on something unique within it!
-	list.SetEquals(func(first, second fmt.Stringer) bool { return first.String() == second.String() })
+	l.SetEquals(func(first, second fmt.Stringer) bool { return first.String() == second.String() })
 	m := model{}
-	m.list = list
+	m.list = l
 
 	m.endResult = endResult
 
@@ -100,7 +99,7 @@ func (m model) View() string {
 func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	if m.list.PrefixGen == nil {
 		// use default
-		m.list.PrefixGen = list.NewDefault()
+		m.list.PrefixGen = list.NewPrefixer()
 	}
 
 	switch msg := msg.(type) {
@@ -213,22 +212,3 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	}
 	return m, nil
 }
-
-type exampleSuffixer struct {
-	viewPos       list.ViewPos
-	currentMarker string
-	markerLenght  int
-}
-
-func (e *exampleSuffixer) InitSuffixer(viewPos list.ViewPos, screen list.ScreenInfo) int {
-	e.viewPos = viewPos
-	e.markerLenght = ansi.PrintableRuneWidth(e.currentMarker)
-	return e.markerLenght
-}
-
-func (e *exampleSuffixer) Suffix(item, line int, selected bool) string {
-	if item == e.viewPos.Cursor && line == 0 {
-		return e.currentMarker
-	}
-	return strings.Repeat(" ", e.markerLenght)
-}

list/list.go

@@ -108,11 +108,6 @@ func (m *Model) Lines() []string {
 out:
 	// Handle list items, start at first visible and go till end of list or visible (break)
 	for index := offset; index < len(m.listItems); index++ {
-		if index >= len(m.listItems) || index < 0 {
-			// TODO log error
-			break
-		}
-
 		item := m.listItems[index]
 
 		lines := m.itemLines(item)
@@ -161,10 +156,6 @@ out:
 			}
 		}
 	}
-	lenght := len(stringLines)
-	if lenght > m.Screen.Height {
-		panic(fmt.Sprintf("can't display %d lines when screen has %d lines.", lenght, m.Screen.Height))
-	}
 	return stringLines
 }