Fix LGTM alert for array element proxy assignment operator (#3453)

jszaday · evan-charmworks · commit f321deb299e0 · 2021-08-19T15:17:49.000-05:00
diff --git a/src/ck-core/ckarray.h b/src/ck-core/ckarray.h
@@ -177,7 +177,8 @@ class CProxyElement_ArrayBase : public CProxy_ArrayBase
 
   CProxyElement_ArrayBase& operator=(const CProxyElement_ArrayBase& other)
   {
-    return *this = CProxyElement_ArrayBase(other);
+    new (this) CProxyElement_ArrayBase(other);
+    return *this;
   }
 
   bool operator==(const CProxyElement_ArrayBase& other)

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,8 @@ class CProxyElement_ArrayBase : public CProxy_ArrayBase`
`177`	`177`
`178`	`178`	`CProxyElement_ArrayBase& operator=(const CProxyElement_ArrayBase& other)`
`179`	`179`	`{`
`180`		`- return *this = CProxyElement_ArrayBase(other);`
	`180`	`+ new (this) CProxyElement_ArrayBase(other);`
	`181`	`+ return *this;`
`181`	`182`	`}`
`182`	`183`
`183`	`184`	`bool operator==(const CProxyElement_ArrayBase& other)`