Refactor detox directory into platforms (#370)

Author: charpeni

.circleci/config.yml

@@ -2,6 +2,7 @@ version: 2.1
 
 aliases:
   - &xcode-version 12.5.1
+  - &node-version '16.12'
   - &save-cache-yarn
     save_cache:
       key: yarn-packages-{{ .Environment.CACHE_VERSION }}-{{ checksum "yarn.lock" }}
@@ -51,6 +52,9 @@ aliases:
     attach_workspace:
       at: ~/react-native-url-polyfill
 
+orbs:
+  node: circleci/[email protected]
+
 executors:
   default:
     docker:
@@ -99,22 +103,13 @@ commands:
           command: |
             detox clean-framework-cache && detox build-framework-cache
       - *save-cache-detox-env
-  test-hermes-ios:
+  install-node:
     steps:
-      - *attach-workspace
-      - *restore-cache-detox-app
-      - run:
-          name: Enable Hermes
-          command: npx shx sed -i "s/:hermes_enabled\s=>\sfalse/:hermes_enabled => true/g" ios/Podfile
-      - install-yarn-dependencies
-      - install-detox
-      - run:
-          name: Install Pods
-          command: |
-            cd ios && pod install
-      - run:
-          name: Run Detox on iOS
-          command: yarn e2e:ios
+      - node/install:
+          node-version: *node-version
+          install-npm: false
+          install-yarn: true
+          yarn-version: 1.22.5
 
 jobs:
   checkout:
@@ -166,10 +161,11 @@ jobs:
       react-native-version:
         type: string
     executor: << parameters.executor >>
-    working_directory: ~/react-native-url-polyfill/detox/rn-<< parameters.react-native-version >>
+    working_directory: ~/react-native-url-polyfill/platforms/react-native/<< parameters.react-native-version >>
     steps:
       - *attach-workspace
       - *restore-cache-detox-app
+      - install-node
       - install-yarn-dependencies
       - install-detox
       - run:
@@ -187,13 +183,14 @@ jobs:
       react-native-version:
         type: string
     executor: android
-    working_directory: ~/react-native-url-polyfill/detox/rn-<< parameters.react-native-version >>
+    working_directory: ~/react-native-url-polyfill/platforms/react-native/<< parameters.react-native-version >>
     steps:
       - *attach-workspace
       - run:
           name: Enable Hermes
           command: sed -i "s/enableHermes:\sfalse/enableHermes:\ true/g" android/app/build.gradle
       - *restore-android-build-cache
+      - install-node
       - install-yarn-dependencies
       - run:
           name: Build APK
@@ -207,9 +204,23 @@ jobs:
       react-native-version:
         type: string
     executor: << parameters.executor >>
-    working_directory: ~/react-native-url-polyfill/detox/rn-<< parameters.react-native-version >>
+    working_directory: ~/react-native-url-polyfill/platforms/react-native/<< parameters.react-native-version >>
     steps:
-      - test-hermes-ios
+      - *attach-workspace
+      - *restore-cache-detox-app
+      - run:
+          name: Enable Hermes
+          command: npx shx sed -i "s/:hermes_enabled\s=>\sfalse/:hermes_enabled => true/g" ios/Podfile
+      - install-node
+      - install-yarn-dependencies
+      - install-detox
+      - run:
+          name: Install Pods
+          command: |
+            cd ios && pod install
+      - run:
+          name: Run Detox on iOS
+          command: yarn e2e:ios
 
 workflows:
   tests:

.eslintignore

@@ -1,2 +1,2 @@
-/detox/
+/platforms/
 index.d.ts

.npmignore

@@ -1,3 +1,3 @@
-detox
+platforms
 *.tgz
 .DS_Store

detox/rn-0.66/.detoxrc.json

@@ -34,12 +34,13 @@
   "devDependencies": {
     "@react-native-community/eslint-config": "3.0.1",
     "chalk": "^4.0.0",
+    "detox": "^18.23.1",
     "eslint": "7.32.0",
     "eslint-plugin-prettier": "4.0.0",
     "execa": "^5.0.0",
     "filesize": "^8.0.0",
     "husky": "^7.0.0",
-    "jest": "^27.2.4",
+    "jest": "^27.3.1",
     "lint-staged": ">=8",
     "metro-react-native-babel-preset": "^0.66.2",
     "ora": "^5.4.1",
@@ -60,7 +61,7 @@
     "preset": "react-native",
     "testPathIgnorePatterns": [
       "/node_modules/",
-      "./detox/"
+      "./platforms/"
     ]
   },
   "lint-staged": {

detox/rn-0.66/e2e/config.json

@@ -1,6 +1,6 @@
 {
   "testRunner": "jest",
-  "runnerConfig": "e2e/config.json",
+  "runnerConfig": "../../detox/config.json",
   "configurations": {
     "ios.sim.release": {
       "type": "ios.simulator",