Add tests for React Native 0.78 (#480)

Author: charpeni

.circleci/config.yml

@@ -1,37 +1,29 @@
 version: 2.1
 
 aliases:
-  - &xcode-version 15.4.0
-  - &node-version '20.10.0'
-  - &yarn-version '1.22.19'
+  - &node-version '22.14.0'
+  - &yarn-version '1.22.22'
 
 orbs:
-  node: circleci/node@5.1.1
-  browser-tools: circleci/browser-tools@1.4.6
+  node: circleci/node@5.3.0
+  browser-tools: circleci/browser-tools@1.5.3
   android: circleci/[email protected]
 
 executors:
   node:
     docker:
-      - image: cimg/node:20.10.0
+      - image: cimg/node:22.14.0
     working_directory: ~/react-native-url-polyfill
     environment:
       NODE_OPTIONS: '--openssl-legacy-provider'
   node-browsers:
     docker:
-      - image: cimg/node:20.10.0-browsers
+      - image: cimg/node:22.14.0-browsers
     environment:
       NODE_OPTIONS: '--openssl-legacy-provider'
-  xcode:
-    macos:
-      xcode: *xcode-version
-    environment:
-      HOMEBREW_NO_AUTO_UPDATE: 1
-      XCODE_VERSION: *xcode-version
-      NODE_OPTIONS: '--openssl-legacy-provider'
   android:
     docker:
-      - image: cimg/android:2023.06.1
+      - image: cimg/android:2023.12.1-node
     resource_class: large
     environment:
       JAVA_TOOL_OPTIONS: '-Xmx1536m'
@@ -194,15 +186,19 @@ jobs:
           command: yarn test
   test-ios:
     parameters:
-      executor:
-        default: xcode
-        type: executor
       react-native-version:
         type: string
+      xcode-version:
+        type: string
       install-yarn:
         type: boolean
         default: true
-    executor: << parameters.executor >>
+    macos:
+      xcode: << parameters.xcode-version >>
+    environment:
+      HOMEBREW_NO_AUTO_UPDATE: 1
+      XCODE_VERSION: << parameters.xcode-version >>
+      NODE_OPTIONS: '--openssl-legacy-provider'
     working_directory: ~/react-native-url-polyfill/platforms/react-native/<< parameters.react-native-version >>
     steps:
       - attach-workspace
@@ -266,31 +262,6 @@ jobs:
           name: Build APK
           command: cd android && ./gradlew assembleRelease
       - save-android-build-cache
-  test-hermes-ios:
-    parameters:
-      executor:
-        default: xcode
-        type: executor
-      react-native-version:
-        type: string
-    executor: << parameters.executor >>
-    working_directory: ~/react-native-url-polyfill/platforms/react-native/<< parameters.react-native-version >>
-    steps:
-      - attach-workspace
-      - restore-cache-detox-app
-      - run:
-          name: Enable Hermes
-          command: npx shx sed -i "s/:hermes_enabled\s=>\sfalse/:hermes_enabled => true/g" ios/Podfile
-      - install-node
-      - install-yarn-dependencies
-      - install-detox
-      - run:
-          name: Install Pods
-          command: |
-            cd ios && pod install
-      - run:
-          name: Run Detox on iOS
-          command: yarn e2e:ios
   test-expo-web:
     parameters:
       expo-version:
@@ -330,25 +301,26 @@ workflows:
           requires:
             - checkout
       - test-ios:
-          matrix:
-            parameters:
-              react-native-version: ['0.72']
+          name: test-ios-0.72
+          react-native-version: '0.72'
+          xcode-version: 15.4.0
+          requires:
+            - lint
+            - test-js
+      - test-ios:
+          name: test-ios-0.78
+          react-native-version: '0.78'
+          xcode-version: 16.2.0
           requires:
             - lint
             - test-js
       - test-android:
           matrix:
             parameters:
-              react-native-version: ['0.68', '0.72']
+              react-native-version: ['0.68', '0.72', '0.78']
           requires:
             - lint
             - test-js
-      # - test-hermes-ios:
-      #     matrix:
-      #       parameters:
-      #         react-native-version: ['0.68']
-      #     requires:
-      #       - test-ios-<< matrix.react-native-version >>
       - test-hermes-android:
           matrix:
             parameters:

package.json

@@ -34,7 +34,8 @@
   },
   "devDependencies": {
     "@react-native-community/eslint-config": "3.2.0",
-    "detox": "20.14.3",
+    "@types/node": "^22.13.10",
+    "detox": "20.34.5",
     "eslint": "8.56.0",
     "eslint-plugin-prettier": "5.1.1",
     "husky": "8.0.3",
@@ -43,10 +44,10 @@
     "metro-react-native-babel-preset": "0.76.7",
     "nanoid": "3.3.7",
     "prettier": "3.1.1",
-    "react": "18.2.0",
-    "react-native": "0.72.1",
+    "react": "19.0.0",
+    "react-native": "0.78.0",
     "react-native-bundle-scale": "1.1.0",
-    "typescript": "5.3.3"
+    "typescript": "5.8.2"
   },
   "peerDependencies": {
     "react-native": "*"

platforms/detox/.detoxrc.js

@@ -37,12 +37,18 @@ module.exports = {
     },
   },
   devices: {
-    simulator: {
+    simulator15: {
       type: 'ios.simulator',
       device: {
         type: 'iPhone 15 Pro',
       },
     },
+    simulator: {
+      type: 'ios.simulator',
+      device: {
+        type: 'iPhone 16 Pro',
+      },
+    },
     attached: {
       type: 'android.attached',
       device: {
@@ -61,6 +67,10 @@ module.exports = {
       device: 'simulator',
       app: 'ios.debug',
     },
+    'ios.sim.release.15': {
+      device: 'simulator15',
+      app: 'ios.release',
+    },
     'ios.sim.release': {
       device: 'simulator',
       app: 'ios.release',

platforms/react-native/0.68/metro.config.js

@@ -14,12 +14,15 @@ module.exports = {
   resolver: {
     blockList: [
       new RegExp(`${reactNativeLib}/node_modules/react-native/.*`),
+      new RegExp(`${reactNativeLib}/node_modules/react/.*`),
       new RegExp(`${reactNativeLib}/platforms/react-native/((?!0.68).).*`),
       new RegExp(`${reactNativeLib}/platforms/expo/.*`),
       new RegExp(path.resolve(__dirname, 'ios/.*')),
     ],
     extraNodeModules: {
       'react-native': path.resolve(__dirname, 'node_modules/react-native'),
+      'react': path.resolve(__dirname, 'node_modules/react'),
+      'react-native-url-polyfill': path.resolve(__dirname, reactNativeLib),
     },
   },
   transformer: {

platforms/react-native/0.72/metro.config.js

@@ -15,12 +15,15 @@ const config = {
   resolver: {
     blockList: [
       new RegExp(`${reactNativeLib}/node_modules/react-native/.*`),
+      new RegExp(`${reactNativeLib}/node_modules/react/.*`),
       new RegExp(`${reactNativeLib}/platforms/react-native/((?!0.72).).*`),
       new RegExp(`${reactNativeLib}/platforms/expo/.*`),
       new RegExp(path.resolve(__dirname, 'ios/.*')),
     ],
     extraNodeModules: {
       'react-native': path.resolve(__dirname, 'node_modules/react-native'),
+      'react': path.resolve(__dirname, 'node_modules/react'),
+      'react-native-url-polyfill': reactNativeLib,
     },
   },
 };

platforms/react-native/0.72/package.json

@@ -8,8 +8,8 @@
     "lint": "eslint .",
     "start": "react-native start",
     "test": "jest",
-    "build:ios": "detox build --configuration ios.sim.release",
-    "test:ios": "detox test --configuration ios.sim.release --cleanup",
+    "build:ios": "detox build --configuration ios.sim.release.15",
+    "test:ios": "detox test --configuration ios.sim.release.15 --cleanup --headless",
     "e2e:ios": "yarn build:ios && yarn test:ios",
     "build:android": "detox build --configuration android.emu.release",
     "test:android": "detox test --configuration android.emu.release",

platforms/react-native/0.72/tsconfig.json

@@ -1,3 +1,3 @@
 {
-  "extends": "@tsconfig/react-native/tsconfig.json"
+  "extends": "@react-native/typescript-config/tsconfig.json"
 }

platforms/react-native/0.78/.bundle/config

@@ -0,0 +1,2 @@
+BUNDLE_PATH: "vendor/bundle"
+BUNDLE_FORCE_RUBY_PLATFORM: 1

platforms/react-native/0.78/.detoxrc.js

@@ -0,0 +1,4 @@
+const detoxConfig = require('../../detox/.detoxrc.js');
+
+/** @type {Detox.DetoxConfig} */
+module.exports = detoxConfig;

platforms/react-native/0.78/.eslintrc.js

@@ -0,0 +1,4 @@
+module.exports = {
+  root: true,
+  extends: '@react-native',
+};