Skip to content

Commit 3c33d87

Browse files
authored
Remove tooltip constructor fallbacks, this.chart and this._chart (#10612)
* remove tooltip fallbacks/backwards compatability in constructor * increase size limit
1 parent fc8a63e commit 3c33d87

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.size-limit.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ module.exports = [
4141
},
4242
{
4343
path: 'dist/chart.js',
44-
limit: '22 KB',
44+
limit: '22.2 KB',
4545
import: '{ CategoryScale, LinearScale, LogarithmicScale, RadialLinearScale, TimeScale, TimeSeriesScale }',
4646
running: false,
4747
modifyWebpackConfig

docs/migration/v4-migration.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,5 @@ A number of changes were made to the configuration options passed to the `Chart`
3131

3232
### General
3333
* Removed fallback to `fontColor` for the legend text and strikethrough color.
34+
* Removed `config._chart` fallback for `this.chart` in the filler plugin.
35+
* Removed `this._chart` in the filler plugin.

src/plugins/plugin.tooltip.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -465,9 +465,7 @@ export class Tooltip extends Element {
465465
this._tooltipItems = [];
466466
this.$animations = undefined;
467467
this.$context = undefined;
468-
// TODO: V4, remove config._chart and this._chart backward compatibility aliases
469-
this.chart = config.chart || config._chart;
470-
this._chart = this.chart;
468+
this.chart = config.chart;
471469
this.options = config.options;
472470
this.dataPoints = undefined;
473471
this.title = undefined;

0 commit comments

Comments
 (0)