height stay at fixed size (px) even with maintainAspectRatio

[AndreaBarghigiani]

Hi all and thanks for this amazing library, I am using it for a while and I have to say that has been a pleasure to work with it so first and foremost congrats to the developers and maintainers 💪

Recently I have started to use it in a Rails application and I've implemented it with Chartkick but I am facing a problem here because I am not able to leverage the maintainAspectRatio option.

The chart is responsive and it adapts to the changes in the width but I see the height set at a fixed value, 300px to be precise.

Reading the documentation and the previous issues I noticed that

Detecting when the canvas size changes can not be done directly from the canvas element. Chart.js uses its parent container to update the canvas render and display sizes. However, this method requires the container to be relatively positioned and dedicated to the chart canvas only.

Since Chartkick does not allow me to set a class to the div that wraps the canvas element I have wrapped it with a custom div and set the following CSS:

.pie-chart__chart {
  > div {
    position: relative;
    height: 100%;
  }
}

In this way I am setting the div positioned as relative and also give it a height but checking at the code it is still 300px 🤔

I tried also to check the option passed via the JavaScript API that Chartkick offers but they seems good from my point of view:

PS: if you think that I shall post this in the Chartkick repo let me know, wrote here because to me seems related with Chart.js