lint samples (#194)

* Upgrade gulp

* lint samples

Author: benmccann

.eslintrc.yml

@@ -6,3 +6,5 @@ parserOptions:
 env:
   browser: true
   node: true
+
+plugins: ['html']

.htmllintrc

@@ -0,0 +1,18 @@
+{
+	"indent-style": "tabs",
+	"line-end-style": false,
+	"spec-char-escape": false,
+	"attr-bans": [
+		"align",
+		"background",
+		"bgcolor",
+		"border",
+		"frameborder",
+		"longdesc",
+		"marginwidth",
+		"marginheight",
+		"scrolling"
+	],
+	"tag-bans": [ "b", "i" ],
+	"id-class-style": false
+}

gulpfile.js

@@ -1,6 +1,7 @@
 var gulp = require('gulp'),
     eslint = require('gulp-eslint'),
     util = require('gulp-util'),
+    htmllint = require('gulp-htmllint'),
     inquirer = require('inquirer'),
     semver = require('semver'),
     fs = require('fs'),
@@ -20,11 +21,13 @@ function run(bin, args, done) {
   ps.on('close', () => done());
 }
 
-gulp.task('default', ['lint', 'build', 'watch']);
 gulp.task('build', buildTask);
 gulp.task('bump', bumpTask);
-gulp.task('lint', lintTask);
+gulp.task('lint-html', lintHtmlTask);
+gulp.task('lint-js', lintJsTask);
+gulp.task('lint', gulp.parallel('lint-html', 'lint-js'));
 gulp.task('watch', watchTask);
+gulp.task('default', gulp.parallel('lint', 'build', 'watch'));
 
 function buildTask(done) {
   run('rollup/bin/rollup', ['-c'], done);
@@ -59,10 +62,12 @@ function bumpTask(complete) {
   });
 }
 
-function lintTask() {
+function lintJsTask() {
   var files = [
+    'samples/**/*.html',
     'samples/**/*.js',
-    'src/**/*.js'
+    'src/**/*.js',
+    'test/**/*.js'
   ];
 
   // NOTE(SB) codeclimate has 'complexity' and 'max-statements' eslint rules way too strict
@@ -81,6 +86,13 @@ function lintTask() {
     .pipe(eslint.failAfterError());
 }
 
+function lintHtmlTask() {
+  return gulp.src('samples/**/*.html')
+    .pipe(htmllint({
+      failOnError: true,
+    }));
+}
+
 function watchTask() {
-  return gulp.watch(srcFiles, ['lint', 'build']);
+  return gulp.watch(srcFiles, gulp.parallel('lint', 'build'));
 }