Skip to content
This repository was archived by the owner on Jun 24, 2021. It is now read-only.

make +rb $~a prioritise ERR_NEEDREGGEDNICK #361

@jesopo

Description

@jesopo

rationale is that prioritising the version that gives the most information about the reason for not being able to join is a good idea, though this makes less sense for +rb nick!*@* when your nick is nick, but you'd still have to address both reasons for not being able to join in any case.

one could argue this should instead be solved by -b $~a but i can imagine people unintentionally having both set or wanting the fallback or whatever, and prioritising +r might lead to fewer confused users.

I assume this is as simple as moving

charybdis/ircd/channel.c

Lines 736 to 737 in 9dd128b

if(chptr->mode.mode & MODE_REGONLY && EmptyString(source_p->user->suser))
i = ERR_NEEDREGGEDNICK;

above
if((is_banned(chptr, source_p, NULL, &ms, forward)) == CHFL_BAN)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions