refactor(ffi): replace implicit drop in cffi with explicit drop(Arc::from_raw(var)) (#7664)

Simon-Laux · web-flow · commit 9d7db202256e · 2026-01-05T19:27:48.000Z
for improved clarity and consistency with existing code.
diff --git a/deltachat-ffi/src/lib.rs b/deltachat-ffi/src/lib.rs
@@ -4773,7 +4773,7 @@ pub unsafe extern "C" fn dc_accounts_unref(accounts: *const dc_accounts_t) {
         eprintln!("ignoring careless call to dc_accounts_unref()");
         return;
     }
-    let _ = Arc::from_raw(accounts);
+    drop(Arc::from_raw(accounts));
 }
 
 #[no_mangle]

Original file line number	Diff line number	Diff line change
`@@ -4773,7 +4773,7 @@ pub unsafe extern "C" fn dc_accounts_unref(accounts: *const dc_accounts_t) {`
`4773`	`4773`	`eprintln!("ignoring careless call to dc_accounts_unref()");`
`4774`	`4774`	`return;`
`4775`	`4775`	`}`
`4776`		`- let _ = Arc::from_raw(accounts);`
	`4776`	`+ drop(Arc::from_raw(accounts));`
`4777`	`4777`	`}`
`4778`	`4778`
`4779`	`4779`	`#[no_mangle]`