Skip serializing bot, direct_chat, and new if they are false

Author: Hocuri

src/statistics.rs

@@ -53,17 +53,30 @@ struct ContactStat {
     id: ContactId,
 
     verified: VerifiedStatus,
+
+    // If one of the boolean properties is false,
+    // we leave them away.
+    // This way, the Json file becomes a lot smaller.
+    #[serde(skip_serializing_if = "is_false")]
     bot: bool,
+
+    #[serde(skip_serializing_if = "is_false")]
     direct_chat: bool,
+
     last_seen: u64,
 
     #[serde(skip_serializing_if = "Option::is_none")]
     transitive_chain: Option<u32>,
 
     /// Whether the contact was established after stats-sending was enabled
+    #[serde(skip_serializing_if = "is_false")]
     new: bool,
 }
 
+fn is_false(b: &bool) -> bool {
+    !b
+}
+
 #[derive(Serialize)]
 struct MessageStats {
     to_verified: u32,
@@ -379,8 +392,8 @@ async fn get_contact_stats(context: &Context, last_old_contact: u32) -> Result<V
             .sql
             .exists(
                 "SELECT COUNT(*)
-            FROM chats_contacts cc INNER JOIN chats
-            WHERE cc.contact_id=? AND chats.type=?",
+                FROM chats_contacts cc INNER JOIN chats
+                WHERE cc.contact_id=? AND chats.type=?",
                 (contact.id, Chattype::Single),
             )
             .await?;

src/statistics/statistics_tests.rs

@@ -70,10 +70,7 @@ async fn test_statistics_one_contact() -> Result<()> {
     let contact_stats = r2.get("contact_stats").unwrap().as_array().unwrap();
     assert_eq!(contact_stats.len(), 1);
     let contact_info = &contact_stats[0];
-    assert_eq!(
-        contact_info.get("bot").unwrap(),
-        &serde_json::Value::Bool(false)
-    );
+    assert!(contact_info.get("bot").is_none());
     assert_eq!(
         contact_info.get("direct_chat").unwrap(),
         &serde_json::Value::Bool(true)