Skip to content

Commit 7054c59

Browse files
authored
Strip library (#99)
As we grow in arch coverage and versions, space matters. Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
1 parent fddb32d commit 7054c59

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

chdb/build.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,10 @@ file ${LIBCHDB}
130130

131131
rm -f ${CHDB_DIR}/*.so
132132
mv ${LIBCHDB} ${CHDB_DIR}/${CHDB_PY_MODULE}
133-
# strip ${CHDB_DIR}/${CHDB_PY_MODULE} || true
134133

135-
# # strip the binary (no debug info at all)
136-
# strip ${CHDB_DIR}/${CHDB_PY_MODULE} || true
134+
# strip the binary (no debug info at all)
135+
strip ${CHDB_DIR}/${CHDB_PY_MODULE} || true
136+
137137
# echo -e "\nAfter strip:"
138138
# echo -e "\nLIBCHDB: ${LIBCHDB}"
139139
# ls -lh ${CHDB_DIR}

0 commit comments

Comments
 (0)