-
-
Notifications
You must be signed in to change notification settings - Fork 66
Open
Labels
bugSomething isn't workingSomething isn't working
Description
When Kodiak starts merging a PR, it enters a loop, polling until the PR is ready to merge. If Kodiak makes a GitHub API request and encounters an error, it will eject from this loop, ignoring the PR and moving on to the next PR in queue.
This is problematic behavior as it can trigger extra updates to PRs. We should gracefully retry on recoverable errors.
Here's where we check for an error:
kodiak/bot/kodiak/queries/__init__.py
Lines 876 to 880 in afd6e59
| try: | |
| res.raise_for_status() | |
| except http.HTTPError: | |
| log.warning("github api request error", res=res, exc_info=True) | |
| return None |
We should audit all of our API requests to ensure we gracefully handle errors.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working