hide the parent terminal and makes only child terminal visible

Author: msivasubramaniaan

code/extensions/che-commands/src/compositeTaskBuilder.ts

@@ -57,15 +57,7 @@ export class CompositeTaskBuilder {
 		}
 
 		if (parallel) {
-			queueMicrotask(() => {
-				execs.forEach((e, index) => {
-					const childTask = this.buildExecTask(e, index === 0);
-
-					vscode.tasks.executeTask(childTask);
-				});
-			});
-
-			return undefined;
+			return this.buildParallelCrossComponent(command, execs);
 		}
 
 		return this.buildSeqCrossComponent(command, execs);
@@ -239,6 +231,64 @@ export class CompositeTaskBuilder {
 		);
 	}
 
+	private buildParallelCrossComponent(
+		command: any,
+		execs: ResolvedExec[],
+	): vscode.Task {
+		const execution = new vscode.CustomExecution(async () => {
+			const writeEmitter = new vscode.EventEmitter<string>();
+			const closeEmitter = new vscode.EventEmitter<number>();
+
+			const pty: vscode.Pseudoterminal = {
+				onDidWrite: writeEmitter.event,
+
+				onDidClose: closeEmitter.event,
+
+				open: () => {
+					execs.forEach((e, index) => {
+						const childTask = this.buildExecTask(e, index === 0);
+
+						vscode.tasks.executeTask(childTask);
+					});
+					closeEmitter.fire(0);
+				},
+
+				close: () => {
+					closeEmitter.fire(0);
+				},
+
+				handleInput: () => {},
+			};
+
+			return pty;
+		});
+
+		const first = execs[0];
+
+		const task = new vscode.Task(
+			{
+				type: "devfile",
+				command: command.id,
+				workdir: first.workdir,
+				component: first.component,
+			},
+			vscode.TaskScope.Workspace,
+			command.composite.label || command.id,
+			"devfile",
+			execution,
+			[],
+		);
+
+		task.presentationOptions = {
+			reveal: vscode.TaskRevealKind?.Never ?? 0,
+			panel: vscode.TaskPanelKind?.Dedicated ?? 1,
+			clear: false,
+			showReuseMessage: false,
+		};
+
+		return task;
+	}
+
 	private buildExecTask(e: ResolvedExec, focus: boolean): vscode.Task {
 		const task = new vscode.Task(
 			{
@@ -262,9 +312,9 @@ export class CompositeTaskBuilder {
 
 		task.presentationOptions = {
 			reveal: focus
-				? vscode.TaskRevealKind.Always
-				: vscode.TaskRevealKind.Silent,
-			panel: vscode.TaskPanelKind.Dedicated,
+				? (vscode.TaskRevealKind.Always ?? 1)
+				: (vscode.TaskRevealKind.Silent ?? 2),
+			panel: vscode.TaskPanelKind.Dedicated ?? 1,
 			clear: false,
 		};
 

code/extensions/che-commands/tests/compositeTaskBuilder.test.ts

@@ -114,14 +114,12 @@ describe("Composite — cross component execution", () => {
 		expect(term.calls.map((c) => c.component)).toEqual(["backend", "frontend"]);
 	});
 
-	test("parallel composite executes all components", async () => {
-		const term = new MockTerminalAPI();
+	test("parallel composite executes all components and opens only child terminals", async () => {
 		let executedTasks: vscode.Task[] = [];
 
-		const listeners: any[] = [];
-
 		(vscode as any).TaskRevealKind = {
-			Never: 0,
+			Always: 1,
+			Silent: 2,
 		};
 
 		(vscode as any).TaskPanelKind = {
@@ -131,34 +129,12 @@ describe("Composite — cross component execution", () => {
 		(vscode as any).tasks = {
 			executeTask: async (task: vscode.Task) => {
 				executedTasks.push(task);
-
-				const exec = task.execution as any;
-				if (exec?.callback) {
-					const pty = await exec.callback();
-					if (pty?.open) {
-						await pty.open();
-					}
-				}
-
-				const fakeExecution = {
-					terminate: () => {},
-				};
-
-				setTimeout(() => {
-					listeners.forEach((l) =>
-						l({ execution: fakeExecution, exitCode: 0 }),
-					);
-				}, 0);
-
-				return fakeExecution;
-			},
-
-			onDidEndTaskProcess: (listener: any) => {
-				listeners.push(listener);
-				return { dispose: () => {} };
+				return { terminate() {} };
 			},
 		};
 
+		const term = new MockTerminalAPI();
+
 		const tasks = await provide(devfile, term);
 
 		await runByName(tasks!, "par");
@@ -170,6 +146,9 @@ describe("Composite — cross component execution", () => {
 			.sort();
 
 		expect(comps).toEqual(["backend", "frontend"]);
+		expect(
+			executedTasks.some((t) => (t.definition as any).command === "par"),
+		).toBe(false);
 	});
 });