updated values for max-lines-per-function and max-lines (#229)

Author: ramaghanta

.github/workflows/check-pr-reviews.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     name: Check PR Reviews
     steps:
-      - name: Check PR Reviews
+      - name: Perform Check of PR Reviews
         uses: checkdigit/github-actions/check-pr-reviews@main
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['22.x', '23.x']
+        node-version: ['22.x', '24.x']
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
@@ -43,7 +43,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['22.x', '23.x']
+        node-version: ['22.x', '24.x']
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4

.github/workflows/publish.yml

@@ -6,11 +6,11 @@ on:
 
 jobs:
   publish:
-    name: Publish to NPM
     runs-on: ubuntu-latest
     permissions:
       contents: read
       id-token: write
+    name: Publish to NPM
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4

index.mjs

@@ -25,7 +25,9 @@ import markdown from '@eslint/markdown';
 import yaml from 'eslint-plugin-yml';
 
 const ignores = [
-  ...(await fs.readFile('.gitignore', 'utf-8')).split('\n').filter((path) => path.trim() !== ''),
+  ...(await fs.readFile('.gitignore', 'utf-8'))
+    .split('\n')
+    .filter((path) => path.trim() !== ''),
   'eslint.config.mjs',
 ];
 const __filename = fileURLToPath(import.meta.url);
@@ -95,8 +97,15 @@ const tsConfigurations = [
       '@typescript-eslint/require-await': 'off',
 
       // sonarjs doesn't implement the no-big-function rule probably because this rule already exists within stock eslint
-      // set to 200 because that is sonar's default
-      'max-lines-per-function': ['error', 200],
+      // increasing this to 250 instead of the default value of 200 because of prettier's printWidth reduced to 80
+      'max-lines-per-function': [
+        'error',
+        {
+          max: 250,
+          skipBlankLines: true,
+          skipComments: true,
+        },
+      ],
 
       // enforce use of curly braces around if statements and discourage one-line ifs
       curly: 'error',
@@ -124,7 +133,15 @@ const tsConfigurations = [
 
       'n/no-restricted-import': [
         'error',
-        ['moment', 'clone', 'fclone', 'lodash', 'underscore', 'fs-extra', '@checkdigit/typescript'],
+        [
+          'moment',
+          'clone',
+          'fclone',
+          'lodash',
+          'underscore',
+          'fs-extra',
+          '@checkdigit/typescript',
+        ],
       ],
 
       'n/no-process-env': 'error',
@@ -292,7 +309,7 @@ const tsConfigurations = [
       'max-lines': [
         'error',
         {
-          max: 500,
+          max: 625,
           skipBlankLines: true,
           skipComments: true,
         },
@@ -373,7 +390,16 @@ const tsConfigurations = [
       // configure this to not report side effects for certain functions
       '@checkdigit/no-side-effects': [
         'error',
-        { excludedIdentifiers: ['debug', 'log', 'memoize', 'Object.freeze', 'promisify', 'Symbol.for'] },
+        {
+          excludedIdentifiers: [
+            'debug',
+            'log',
+            'memoize',
+            'Object.freeze',
+            'promisify',
+            'Symbol.for',
+          ],
+        },
       ],
     },
   },