Refactor properties to nullable types for improved flexibility in authentication models (#495)

Author: armando-rodriguez-cko

src/CheckoutSdk/Authentication/Standalone/Common/AccountInfo/AccountInfo.cs

@@ -13,7 +13,7 @@ public class AccountInfo
         /// [Optional]
         /// [ 0 .. 9999 ]
         /// </summary>
-        public double PurchaseCount { get; set; }
+        public long? PurchaseCount { get; set; }
 
         /// <summary>
         /// The length of time that the payment account was enrolled in the cardholder's account.
@@ -26,7 +26,7 @@ public class AccountInfo
         /// [Optional]
         /// [ 0 .. 999 ]
         /// </summary>
-        public double AddCardAttempts { get; set; }
+        public long? AddCardAttempts { get; set; }
 
         /// <summary>
         /// Indicates when the shipping address used for this transaction was first used.
@@ -38,21 +38,21 @@ public class AccountInfo
         /// Indicates if the Cardholder Name on the account is identical to the shipping Name used for this transaction.
         /// [Optional]
         /// </summary>
-        public bool AccountNameMatchesShippingName { get; set; }
+        public bool? AccountNameMatchesShippingName { get; set; }
 
         /// <summary>
         /// Indicates whether suspicious activity on the cardholder account has been observed.
         /// [Optional]
         /// </summary>
-        public bool SuspiciousAccountActivity { get; set; }
+        public bool? SuspiciousAccountActivity { get; set; }
 
         /// <summary>
         /// The number of transactions (successful and abandoned) for the cardholder account across all payment accounts
         /// in the previous 24 hours
         /// [Optional]
         /// [ 0 .. 999 ]
         /// </summary>
-        public double TransactionsToday { get; set; }
+        public long? TransactionsToday { get; set; }
 
         /// <summary>
         /// [DEPRECATED]
@@ -77,7 +77,7 @@ public class AccountInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountChange { get; set; }
+        public DateTime? AccountChange { get; set; }
 
         /// <summary>
         /// The amount of time since the cardholder’s account information with the 3DS Requestor was last changed.
@@ -94,15 +94,15 @@ public class AccountInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountDate { get; set; }
+        public DateTime? AccountDate { get; set; }
 
         /// <summary>
         /// The UTC date and time the cardholder’s account with the 3DS Requestor was last reset or had a password
         /// change, in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountPasswordChange { get; set; }
+        public DateTime? AccountPasswordChange { get; set; }
 
         /// <summary>
         /// The amount of time since the cardholder’s account with the 3DS Requestor was last reset or had a password
@@ -119,23 +119,23 @@ public class AccountInfo
         /// <= 3
         /// <= 999
         /// </summary>
-        public int TransactionsPerYear { get; set; }
+        public long? TransactionsPerYear { get; set; }
 
         /// <summary>
         /// The UTC date and time the payment account was enrolled in the cardholder’s account with the 3DS Requestor,
         /// in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime PaymentAccountAge { get; set; }
+        public DateTime? PaymentAccountAge { get; set; }
 
         /// <summary>
         /// The UTC date and time the shipping address used for the transaction was first used with the 3DS Requestor,
         /// in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime ShippingAddressUsage { get; set; }
+        public DateTime? ShippingAddressUsage { get; set; }
 
         /// <summary>
         /// The type of account, in the case of a card product with multiple accounts.

src/CheckoutSdk/Authentication/Standalone/Common/AccountInfo/ThreeDsRequestorAuthenticationInfo/ThreeDsRequestorAuthenticationInfo.cs

@@ -19,7 +19,7 @@ public class ThreeDsRequestorAuthenticationInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime ThreeDsReqAuthTimestamp { get; set; }
+        public DateTime? ThreeDsReqAuthTimestamp { get; set; }
 
         /// <summary>
         /// Data that documents and supports a specific authentication process.

src/CheckoutSdk/Authentication/Standalone/Common/Installment/Installment.cs

@@ -17,14 +17,14 @@ public class Installment
         public int NumberOfPayments { get; set; }
 
         /// <summary>
-        /// Default:  1 Indicates the minimum number of days between authorisations. If no value is specified for an
+        /// Default: 1 Indicates the minimum number of days between authorisations. If no value is specified for an
         /// installment authentication type the default value will be used.
         /// [Optional]
         /// </summary>
-        public int DaysBetweenPayments { get; set; } = 1;
+        public int? DaysBetweenPayments { get; set; } = 1;
 
         /// <summary>
-        /// Default:  99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
+        /// Default: 99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
         /// value is specified for an installment authentication type the default value will be used.
         /// [Optional]
         /// </summary>

src/CheckoutSdk/Authentication/Standalone/Common/MerchantRiskInfo/MerchantRiskInfo.cs

@@ -1,3 +1,4 @@
+using Checkout.Common;
 using System;
 
 namespace Checkout.Authentication.Standalone.Common.MerchantRiskInfo
@@ -26,13 +27,13 @@ public class MerchantRiskInfo
         /// date.
         /// [Optional]
         /// </summary>
-        public bool IsPreorder { get; set; }
+        public bool? IsPreorder { get; set; }
 
         /// <summary>
         /// Indicates whether the cardholder is reordering previously purchased merchandise.
         /// [Optional]
         /// </summary>
-        public bool IsReorder { get; set; }
+        public bool? IsReorder { get; set; }
 
         /// <summary>
         /// Indicates the shipping method chosen for the transaction. Please choose an option that accurately describes
@@ -59,7 +60,7 @@ public class MerchantRiskInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime PreOrderDate { get; set; }
+        public DateTime? PreOrderDate { get; set; }
 
         /// <summary>
         /// The total purchase amount, in major units. For example, the major unit amount for a gift card purchase of
@@ -75,7 +76,7 @@ public class MerchantRiskInfo
         /// [Optional]
         /// 3 characters
         /// </summary>
-        public string GiftCardCurrency { get; set; }
+        public Currency? GiftCardCurrency { get; set; }
 
         /// <summary>
         /// The total number of individual prepaid cards, gift cards, or gift codes purchased. Only applicable for

src/CheckoutSdk/Authentication/Standalone/Common/Recurring/Recurring.cs

@@ -8,14 +8,14 @@ namespace Checkout.Authentication.Standalone.Common.Recurring
     public class Recurring
     {
         /// <summary>
-        /// Default:  1 Indicates the minimum number of days between authorisations. If no value is specified for a
+        /// Default: 1 Indicates the minimum number of days between authorisations. If no value is specified for a
         /// recurring authentication type the default value will be used.
         /// [Optional]
         /// </summary>
-        public int DaysBetweenPayments { get; set; } = 1;
+        public int? DaysBetweenPayments { get; set; } = 1;
 
         /// <summary>
-        /// Default:  99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
+        /// Default: 99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
         /// value is specified for a recurring authentication type the default value will be used.
         /// [Optional]
         /// </summary>

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Card/Metadata/Metadata.cs

@@ -1,3 +1,5 @@
+using Checkout.Common;
+
 namespace Checkout.Authentication.Standalone.Common.Responses.Card.Metadata
 {
     /// <summary>
@@ -28,7 +30,7 @@ public class Metadata
         /// The two letter alpha country code of the card issuer.
         /// [Optional]
         /// </summary>
-        public string IssuerCountry { get; set; }
+        public CountryCode? IssuerCountry { get; set; }
 
         /// <summary>
         /// The issuer/card scheme product identifier.

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Certificates/Certificates.cs

@@ -31,6 +31,6 @@ public class Certificates
         /// server (ACS). Each array element is a Base64 URL-encoded DER-encoded X.509 certificate.
         /// [Optional]
         /// </summary>
-        public IList<object> CaPublicAll { get; set; }
+        public IList<string> CaPublicAll { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/Common/Responses/GoogleSpa/Token/Token.cs

@@ -16,12 +16,12 @@ public class Token
         /// Expiry month of the token
         /// [Optional]
         /// </summary>
-        public double ExpiryMonth { get; set; }
+        public int? ExpiryMonth { get; set; }
 
         /// <summary>
         /// Expiry year of the token
         /// [Optional]
         /// </summary>
-        public double ExpiryYear { get; set; }
+        public int? ExpiryYear { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Optimization/Optimization.cs

@@ -12,7 +12,7 @@ public class Optimization
         /// Indicates if any optimization has been applied
         /// [Optional]
         /// </summary>
-        public bool Optimized { get; set; }
+        public bool? Optimized { get; set; }
 
         /// <summary>
         /// The optimization framework applied

src/CheckoutSdk/Authentication/Standalone/Common/Responses/PreferredExperiences/GoogleSpa/GoogleSpa.cs

@@ -17,6 +17,6 @@ public class GoogleSpa
         /// Reason(s) why processing the experience was unsuccessful.
         /// [Optional]
         /// </summary>
-        public IList<object> Reason { get; set; }
+        public IList<string> Reason { get; set; }
     }
 }