Add Discount Enum Item (#442)

armando-rodriguez-cko · web-flow · commit efeecfdf35b1 · 2025-01-09T18:19:01.000+01:00
* Add discount enum item

* Update test. Previous unavailable
diff --git a/src/CheckoutSdk/Payments/Contexts/PaymentContextItemType.cs b/src/CheckoutSdk/Payments/Contexts/PaymentContextItemType.cs
@@ -9,5 +9,8 @@ public enum PaymentContextItemType
         
         [EnumMember(Value = "digital")]
         Digital,
+        
+        [EnumMember(Value = "discount")]
+        Discount,
     }
 }
diff --git a/test/CheckoutSdkTest/CheckoutSdkIntegrationTest.cs b/test/CheckoutSdkTest/CheckoutSdkIntegrationTest.cs
@@ -17,10 +17,9 @@ public async Task ShouldInstantiateClientWithCustomHttpClientFactory()
         {
             var checkoutApi = CheckoutSdk
                 .Builder()
-                .Previous()
                 .StaticKeys()
-                .PublicKey(System.Environment.GetEnvironmentVariable("CHECKOUT_PREVIOUS_PUBLIC_KEY"))
-                .SecretKey(System.Environment.GetEnvironmentVariable("CHECKOUT_PREVIOUS_SECRET_KEY"))
+                .PublicKey(System.Environment.GetEnvironmentVariable("CHECKOUT_DEFAULT_PUBLIC_KEY"))
+                .SecretKey(System.Environment.GetEnvironmentVariable("CHECKOUT_DEFAULT_SECRET_KEY"))
                 .Environment(Environment.Sandbox)
                 .HttpClientFactory(new TestingClientFactory())
                 .Build();
@@ -29,7 +28,7 @@ public async Task ShouldInstantiateClientWithCustomHttpClientFactory()
 
             try
             {
-                await checkoutApi.EventsClient().RetrieveAllEventTypes();
+                await checkoutApi.WorkflowsClient().GetWorkflows();
                 throw new XunitException();
             }
             catch (CheckoutApiException ex)
@@ -45,10 +44,9 @@ public async Task ShouldInstantiateClientWithSubdomainFactory()
         {
             var checkoutApi = CheckoutSdk
                 .Builder()
-                .Previous()
                 .StaticKeys()
-                .PublicKey(System.Environment.GetEnvironmentVariable("CHECKOUT_PREVIOUS_PUBLIC_KEY"))
-                .SecretKey(System.Environment.GetEnvironmentVariable("CHECKOUT_PREVIOUS_SECRET_KEY"))
+                .PublicKey(System.Environment.GetEnvironmentVariable("CHECKOUT_DEFAULT_PUBLIC_KEY"))
+                .SecretKey(System.Environment.GetEnvironmentVariable("CHECKOUT_DEFAULT_SECRET_KEY"))
                 .Environment(Environment.Sandbox)
                 .EnvironmentSubdomain(System.Environment.GetEnvironmentVariable("CHECKOUT_MERCHANT_SUBDOMAIN"))
                 .HttpClientFactory(new TestingClientFactory())
@@ -58,7 +56,7 @@ public async Task ShouldInstantiateClientWithSubdomainFactory()
 
             try
             {
-                await checkoutApi.EventsClient().RetrieveAllEventTypes();
+                await checkoutApi.WorkflowsClient().GetWorkflows();
                 throw new XunitException();
             }
             catch (CheckoutApiException ex)
diff --git a/test/CheckoutSdkTest/Instruments/InstrumentsIntegrationTest.cs b/test/CheckoutSdkTest/Instruments/InstrumentsIntegrationTest.cs
@@ -114,7 +114,7 @@ private async Task ShouldUpdateCardInstrument()
             var updateCardInstrument = new UpdateCardInstrumentRequest
             {
                 ExpiryMonth = 12,
-                ExpiryYear = 2024,
+                ExpiryYear = 2030,
                 Name = "John Doe",
                 Customer = new UpdateCustomerRequest {Id = tokenInstrument.Customer.Id, Default = true},
                 AccountHolder = new AccountHolder
@@ -148,7 +148,7 @@ private async Task ShouldUpdateCardInstrument()
             cardResponse.Id.ShouldNotBeNull();
             cardResponse.Fingerprint.ShouldNotBeNull();
             cardResponse.ExpiryMonth.ShouldBe(12);
-            cardResponse.ExpiryYear.ShouldBe(2024);
+            cardResponse.ExpiryYear.ShouldBe(2030);
             cardResponse.Customer.Default.ShouldBeTrue();
             cardResponse.AccountHolder.FirstName.ShouldBe("John");
             cardResponse.AccountHolder.LastName.ShouldBe("Doe");
diff --git a/test/CheckoutSdkTest/Payments/PaymentsClientTest.cs b/test/CheckoutSdkTest/Payments/PaymentsClientTest.cs
@@ -135,7 +135,7 @@ private async Task ShouldRequestPayment_IdempotencyKey()
                     Stored = false,
                     BillingAddress = new Address(),
                     ExpiryMonth = 12,
-                    ExpiryYear = 2024,
+                    ExpiryYear = 2030,
                     TokenType = NetworkTokenType.Vts
                 }
             };
diff --git a/test/CheckoutSdkTest/Payments/PayoutsIntegrationTest.cs b/test/CheckoutSdkTest/Payments/PayoutsIntegrationTest.cs
@@ -27,7 +27,7 @@ private async Task ShouldMakeCardPayoutPayments()
                     {
                         Number = "5219565036325411",
                         ExpiryMonth = 12,
-                        ExpiryYear = 2024,
+                        ExpiryYear = 2030,
                         AccountHolder = new AccountHolder
                         {
                             Type = AccountHolderType.Individual,
@@ -50,7 +50,7 @@ private async Task ShouldMakeCardPayoutPayments()
                                 Type = AccountHolderIdentificationType.Passport,
                                 Number = "E2341",
                                 IssuingCountry = CountryCode.FR,
-                                DateOfExpiry = "2024-05-05"
+                                DateOfExpiry = "2030-05-05"
                             },
                             Email = "jonh.smith@checkout.com"
                         }
diff --git a/test/CheckoutSdkTest/Payments/Previous/RefundPaymentsIntegrationTest.cs b/test/CheckoutSdkTest/Payments/Previous/RefundPaymentsIntegrationTest.cs
@@ -7,7 +7,7 @@ namespace Checkout.Payments.Previous
 {
     public class RefundPaymentsIntegrationTest : AbstractPaymentsIntegrationTest
     {
-        [Fact]
+        [Fact(Skip = "unavailable")]
         private async Task ShouldRefundCardPayment()
         {
             var paymentResponse = await MakeCardPayment(true);
@@ -23,7 +23,7 @@ private async Task ShouldRefundCardPayment()
             response.GetLink("payment").ShouldNotBeNull();
         }
 
-        [Fact]
+        [Fact(Skip = "unavailable")]
         private async Task ShouldRefundCardPayment_Idempotently()
         {
             var paymentResponse = await MakeCardPayment(true);
diff --git a/test/CheckoutSdkTest/Payments/Previous/RequestPaymentsIntegrationTest.cs b/test/CheckoutSdkTest/Payments/Previous/RequestPaymentsIntegrationTest.cs
@@ -159,7 +159,7 @@ private async Task ShouldMakeCardVerification()
             paymentResponse.HasLink("void").ShouldBeFalse();
         }
 
-        [Fact]
+        [Fact(Skip = "unavailable")]
         private async Task ShouldMakeCard3dsPayment()
         {
             var paymentResponse = await Make3dsCardPayment();
diff --git a/test/CheckoutSdkTest/Payments/Previous/RequestPayoutsIntegrationTest.cs b/test/CheckoutSdkTest/Payments/Previous/RequestPayoutsIntegrationTest.cs
@@ -11,7 +11,7 @@ namespace Checkout.Payments.Previous
 {
     public class RequestPayoutsIntegrationTest : AbstractPaymentsIntegrationTest
     {
-        [Fact]
+        [Fact(Skip = "unavailable")]
         private async Task ShouldRequestPayout()
         {
             var phone = new Phone {CountryCode = "44", Number = "020 222333"};
diff --git a/test/CheckoutSdkTest/Sessions/SessionsClientTest.cs b/test/CheckoutSdkTest/Sessions/SessionsClientTest.cs
@@ -56,7 +56,7 @@ private async Task ShouldRequestSessionCreateSessionOkResponse()
             {
                 Source = new SessionNetworkTokenSource
                 {
-                    Token = "token", ExpiryMonth = 12, ExpiryYear = 2024, Name = "name"
+                    Token = "token", ExpiryMonth = 12, ExpiryYear = 2030, Name = "name"
                 }
             };
             var response = new CreateSessionOkResponse

Original file line number	Diff line number	Diff line change
`@@ -9,5 +9,8 @@ public enum PaymentContextItemType`
`9`	`9`
`10`	`10`	`[EnumMember(Value = "digital")]`
`11`	`11`	`Digital,`
	`12`	`+`
	`13`	`+ [EnumMember(Value = "discount")]`
	`14`	`+ Discount,`
`12`	`15`	`}`
`13`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private async Task ShouldRequestPayment_IdempotencyKey()`
`135`	`135`	`Stored = false,`
`136`	`136`	`BillingAddress = new Address(),`
`137`	`137`	`ExpiryMonth = 12,`
`138`		`- ExpiryYear = 2024,`
	`138`	`+ ExpiryYear = 2030,`
`139`	`139`	`TokenType = NetworkTokenType.Vts`
`140`	`140`	`}`
`141`	`141`	`};`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ private async Task ShouldMakeCardPayoutPayments()`
`27`	`27`	`{`
`28`	`28`	`Number = "5219565036325411",`
`29`	`29`	`ExpiryMonth = 12,`
`30`		`- ExpiryYear = 2024,`
	`30`	`+ ExpiryYear = 2030,`
`31`	`31`	`AccountHolder = new AccountHolder`
`32`	`32`	`{`
`33`	`33`	`Type = AccountHolderType.Individual,`
`@@ -50,7 +50,7 @@ private async Task ShouldMakeCardPayoutPayments()`
`50`	`50`	`Type = AccountHolderIdentificationType.Passport,`
`51`	`51`	`Number = "E2341",`
`52`	`52`	`IssuingCountry = CountryCode.FR,`
`53`		`- DateOfExpiry = "2024-05-05"`
	`53`	`+ DateOfExpiry = "2030-05-05"`
`54`	`54`	`},`
`55`	`55`	`Email = "[email protected]"`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace Checkout.Payments.Previous`
`7`	`7`	`{`
`8`	`8`	`public class RefundPaymentsIntegrationTest : AbstractPaymentsIntegrationTest`
`9`	`9`	`{`
`10`		`- [Fact]`
	`10`	`+ [Fact(Skip = "unavailable")]`
`11`	`11`	`private async Task ShouldRefundCardPayment()`
`12`	`12`	`{`
`13`	`13`	`var paymentResponse = await MakeCardPayment(true);`
`@@ -23,7 +23,7 @@ private async Task ShouldRefundCardPayment()`
`23`	`23`	`response.GetLink("payment").ShouldNotBeNull();`
`24`	`24`	`}`
`25`	`25`
`26`		`- [Fact]`
	`26`	`+ [Fact(Skip = "unavailable")]`
`27`	`27`	`private async Task ShouldRefundCardPayment_Idempotently()`
`28`	`28`	`{`
`29`	`29`	`var paymentResponse = await MakeCardPayment(true);`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ private async Task ShouldMakeCardVerification()`
`159`	`159`	`paymentResponse.HasLink("void").ShouldBeFalse();`
`160`	`160`	`}`
`161`	`161`
`162`		`- [Fact]`
	`162`	`+ [Fact(Skip = "unavailable")]`
`163`	`163`	`private async Task ShouldMakeCard3dsPayment()`
`164`	`164`	`{`
`165`	`165`	`var paymentResponse = await Make3dsCardPayment();`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace Checkout.Payments.Previous`
`11`	`11`	`{`
`12`	`12`	`public class RequestPayoutsIntegrationTest : AbstractPaymentsIntegrationTest`
`13`	`13`	`{`
`14`		`- [Fact]`
	`14`	`+ [Fact(Skip = "unavailable")]`
`15`	`15`	`private async Task ShouldRequestPayout()`
`16`	`16`	`{`
`17`	`17`	`var phone = new Phone {CountryCode = "44", Number = "020 222333"};`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ private async Task ShouldRequestSessionCreateSessionOkResponse()`
`56`	`56`	`{`
`57`	`57`	`Source = new SessionNetworkTokenSource`
`58`	`58`	`{`
`59`		`- Token = "token", ExpiryMonth = 12, ExpiryYear = 2024, Name = "name"`
	`59`	`+ Token = "token", ExpiryMonth = 12, ExpiryYear = 2030, Name = "name"`
`60`	`60`	`}`
`61`	`61`	`};`
`62`	`62`	`var response = new CreateSessionOkResponse`