Issue #98: Fixed FinalLocalVariable recipe bug

Author: Anmol202005

src/main/java/org/checkstyle/autofix/recipe/FinalLocalVariable.java

@@ -85,7 +85,10 @@ public J.VariableDeclarations visitVariableDeclarations(
                         .getVariables().get(0);
                 if (isAtViolationLocation(variable)) {
                     final List<J.Modifier> modifiers = new ArrayList<>();
-                    modifiers.add(new J.Modifier(Tree.randomId(), Space.EMPTY,
+
+                    final Space finalPrefix = declarations.getTypeExpression().getPrefix();
+
+                    modifiers.add(new J.Modifier(Tree.randomId(), finalPrefix,
                             Markers.EMPTY, null, J.Modifier.Type.Final, new ArrayList<>()));
                     modifiers.addAll(declarations.getModifiers());
                     declarations = declarations.withModifiers(modifiers)

src/test/java/org/checkstyle/autofix/recipe/FinalLocalVariableTest.java

@@ -46,4 +46,9 @@ void enhancedForLoop() throws Exception {
         verify("EnhancedForLoop");
     }
 
+    @Test
+    void annotationDeclaration() throws Exception {
+        verify("AnnotationDeclaration");
+    }
+
 }

src/test/resources/org/checkstyle/autofix/recipe/finallocalvariable/annotationdeclaration/DiffAnnotationDeclaration.diff

@@ -0,0 +1,21 @@
+--- src/test/resources/org/checkstyle/autofix/recipe/finallocalvariable/annotationdeclaration/InputAnnotationDeclaration.java
++++ src/test/resources/org/checkstyle/autofix/recipe/finallocalvariable/annotationdeclaration/OutputAnnotationDeclaration.java
+@@ -11,14 +11,14 @@
+ 
+ import javax.annotation.Nonnull;
+ 
+-public class InputAnnotationDeclaration {
++public class OutputAnnotationDeclaration {
+     public void basicLocalVariables() {
+-        @Nonnull String name = "John Doe";         // violation, "should be declared final"
++        @Nonnull final String name = "John Doe";
+ 
+         @Nonnull
+-        @Deprecated String gender = "Male";         // violation, "should be declared final"
++        @Deprecated final String gender = "Male";
+ 
+         @Nonnull @Deprecated
+-        String text = "Hello";         // violation, "should be declared final"
++        final String text = "Hello";
+     }
+ }

src/test/resources/org/checkstyle/autofix/recipe/finallocalvariable/annotationdeclaration/InputAnnotationDeclaration.java

@@ -0,0 +1,24 @@
+/*xml
+<module name="Checker">
+  <module name="TreeWalker">
+    <module name="com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck"/>
+  </module>
+</module>
+
+*/
+
+package org.checkstyle.autofix.recipe.finallocalvariable.annotationdeclaration;
+
+import javax.annotation.Nonnull;
+
+public class InputAnnotationDeclaration {
+    public void basicLocalVariables() {
+        @Nonnull String name = "John Doe";         // violation, "should be declared final"
+
+        @Nonnull
+        @Deprecated String gender = "Male";         // violation, "should be declared final"
+
+        @Nonnull @Deprecated
+        String text = "Hello";         // violation, "should be declared final"
+    }
+}

src/test/resources/org/checkstyle/autofix/recipe/finallocalvariable/annotationdeclaration/OutputAnnotationDeclaration.java

@@ -0,0 +1,24 @@
+/*xml
+<module name="Checker">
+  <module name="TreeWalker">
+    <module name="com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck"/>
+  </module>
+</module>
+
+*/
+
+package org.checkstyle.autofix.recipe.finallocalvariable.annotationdeclaration;
+
+import javax.annotation.Nonnull;
+
+public class OutputAnnotationDeclaration {
+    public void basicLocalVariables() {
+        @Nonnull final String name = "John Doe";
+
+        @Nonnull
+        @Deprecated final String gender = "Male";
+
+        @Nonnull @Deprecated
+        final String text = "Hello";
+    }
+}