Run existing recipes against old and large codebase

[rdiachenko]

We need to test current recipes we built against old and large Java codebase. We need to do this now to:

• validate recipe logic, after we apply them the codebase must still be compilable
• validate end-to-end execution: Checkstyle -> Report -> Recipe Execution
• visually check the diff produced by recipes is valid
• check execution time

Repo to consider for testing https://github.com/apache/hbase. I clonned master, and build it on using Java11 on localhost:

❯ mvn clean package -DskipTests
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:57 min
[INFO] Finished at: 2025-08-10T21:51:26+01:00
[INFO] ------------------------------------------------------------------------

hbase on  master via ☕ v11.0.28 took 3m58s

❯ java -version
openjdk version "11.0.28" 2025-07-15
OpenJDK Runtime Environment Homebrew (build 11.0.28+0)
OpenJDK 64-Bit Server VM Homebrew (build 11.0.28+0, mixed mode)

hbase on  master via ☕ v11.0.28

❯ find . -type f -name "*.java" | wc -l
    5265

It has 5265 Java files, which makes it a solid candidate for testing.

The result of this issue should be:

• checkstyle config for all current recipes we support
• checkstyle report after running it against the repo
• code diff after executing recipes
• summary and execution time before / after recipe execution

[Anmol202005]

Recipe ran successfully for the child module https://github.com/apache/hbase/tree/master/hbase-backup
Since hbase follows a multi module structure a diff checkstyle-report is generated for each module and therefore rewrite has to be configured for each child module separately.

Link to commit: Anmol202005/hbase@6aaa38c

Works as expected.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.707 s

Changes made to our project (Checkstyle - openrewrite - recipes)

• Moved rewrite.yml from src/resources/META-INF to root directory (Issue created: Move rewrite.yml from src/resources/META-INF to root directory #93)
• Since Checkstyle runs from the root of the project therefore the report contains absolute path of each file where as since rewrite runs on a sub-modular level a relative path is produced by it. Hence changed the comparison logic to:

&& Path.of(violation.getFileName()).endsWith(sourcePath);

instead of .equals().

[rdiachenko]

1. Could you confirm when you run Checkstyle after OpenRewrite fixes, it gives 0 violations?

Since Checkstyle runs from the root of the project therefore the report contains absolute path of each file where as since rewrite runs on a sub-modular level a relative path is produced by it. Hence changed the comparison logic to

I suppose we need to apply this change to the main logic. Can you create a PR as part of this issue to fix it?

[Anmol202005]

1. Could you confirm when you run Checkstyle after OpenRewrite fixes, it gives 0 violations?

Yes, no violation is found.

[Anmol202005]

I suppose we need to apply this change to the main logic. Can you create a PR as part of this issue to fix it?

done #97

[Anmol202005]

Bug found in FinalLocalVariable as follows:

before:

static Scan createScanForOrigBulkLoadedFiles(@Nullable TableName table) {

After:

static Scan createScanForOrigBulkLoadedFiles(@Nullablefinal TableName table) {

should be:

static Scan createScanForOrigBulkLoadedFiles(@Nullable final TableName table) {

Created Issue: #98

[rdiachenko]

@Anmol202005 to close this issue, could you add a section into README.md, which will describe step by step how to use Checkstyle autofix recipe on the project. Please mention that having Checkstyle is a prerequisite, describe reipe configuraiton options, the sequence of running (Chekcktyle must run first to generate needed reports), and an example of rewrite.yml and its location for the autofix recipe.

The goal is as follow: I have a project and want to use autofix module, I open REAME, follow the steps and have my project configured and running the autofix recipe.