Issue #55: updated computeColumnPosition #56
Merged
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Anmol202005 please resolve conflicts and make sure this case is fixed #54 (comment) |
Collaborator
Author
@rdiachenko Done, |
rdiachenko
approved these changes
Jul 20, 2025
| return computePosition(tree, targetElement, cursor, this::calculateColumnOffset); | ||
| return computePosition(tree, targetElement, cursor, out -> { | ||
| int column = calculateColumnOffset(out); | ||
| if (((J.Literal) targetElement).getValueSource().matches("^[+-].*")) { |
Member
There was a problem hiding this comment.
I have some doubts for this regex match, it doesn't feel right and we may miss other edge cases. Let's rethink this when we get another use case this logic doesn't cover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #55
Updated method to count and add symbol characters to the base column offset calculation.
follow up of: #54